Repository navigation
Refactor DataUri parsing and improve HTML entity handling - #255
Merged
Merged
Conversation
onizet
commented
Oct 23, 2026
Owner
- Refactor the DataUri parsing to use ReadOnlySpan and avoid excessive string allocation.
- DataUri now provide a break-circuit if the uri is not an image
- DataUri is no longer a public class
- Merge the parsing logic of HtmlAttributeCollection with SplitCompositeAttribute. This gives the robust escaping parsing (parenthesis and quote).
- HttpUtility is no longer needed and the code was referring to HTML4 which is largely outdated.
…e the array length.
…rsing from SplitCompositeAttribute
…o a more clean and maintainable code (not relying on abs vs relative index).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.