Repository navigation
lookup: migrate prom-client to @prometheus-io/client - #1217
Open
MikeMcC399 wants to merge 1 commit into
Open
MikeMcC399 wants to merge 1 commit into
MikeMcC399 wants to merge 1 commit into
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2127 2127
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MikeMcC399
marked this pull request as ready for review
October 24, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prom-clientdeprecated and moved to@prometheus-io/client#1216Situation
The npm package prom-client is deprecated. The repo https://github.com/siimon/prom-client redirects to https://github.com/prometheus/client_js .
The final version of
prom-clientwas 15.1.3, published in June 2024.cigtm prom-clientconfusingly reports it has testedprom-client@0.16.0although there is no such package available. It actually tests@prometheus-io/client@0.16.0.With the package migration, the maintainers have also changed and https://github.com/prometheus/client_js/blob/main/MAINTAINERS.md lists:
Change
prom-clientto@prometheus-io/clientChecklist
npm testpasseshere
cc: @jdmarshall @zbjornson