Repository navigation
Conversation
…(v2) Co-Authored-By: Claude Code <noreply@anthropic.com>
|
@lx3133584 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4793 / commit 50fb1a1.
In
src/presets/cloudflare/utils.ts,relative,dirname, andextnamewere imported from Node's built-innode:path. On Windows,node:path.relative(...)emits Windows-style backslashes (e.g...\publicinstead of../public).This caused the newly added unit tests in
test/unit/cloudflare-config.test.tsto fail on Windows CI with:Wrangler configurations require normalized POSIX paths across all operating systems.
Changes
src/presets/cloudflare/utils.ts, replaceimport { relative, dirname, extname } from "node:path"with imports frompathe(dirname, extname, join, relative, resolve).patheguarantees normalized forward-slash paths on all platforms.test/unit/cloudflare-config.test.ts, assertgenerated.assets.directorydoes not contain backslashes.Verification
vitest run test/unit/cloudflare-config.test.tspassed (16 tests).vitest run test/unit/passed (all 17 suites, 99 tests).unbuildsucceeded.eslintandprettier -cpassed with 0 errors.🤖 Generated with Claude Code