Repository navigation
fix(prepare): keep public assets inside output dir when cleaning - #4798
Merged
Merged
Conversation
Backport of #4685 to v2. Instead of throwing, warn and clean everything except the public assets source directory.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
pi0
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4685 to v2.
prepare()used torm -rfthe output dirs even when apublicAssetsdir was inside one of them (e.g.dist/clientwithcloudflare-pages), so the assets were silently deleted. On main this now throws. v2 is a stable line, so here it logs a warning and cleans everything in that output dir except the asset dir instead of failing the build. It also handles symlinks, and output dirs that are themselves symlinks keep the old behavior. Main'sgeneratedAssetDirsoption is not ported because v2 has no Vite plugin.🤖 Generated with AI assistant