Repository navigation
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
091cad1 to
a52d284
Compare
There was a problem hiding this comment.
As an overall comment, the solution needs to be application agnostic as we will want more than deck board in the future, and we cannot have a custom handling for each new ressources that we want to dispay.
This means that we need to create a propre API for such thing, where apps can register ressources to be displayed. Then circles would simply consume this API to display an arbitrary number of ressources without needing to know about them. This would be really close to the smart picker widget API, so maybe we can extend it, or inspire ourselves from it for the new API.
Co-authored-by: Copilot <copilot@github.com> GPT-6.1 Sol Signed-off-by: Stefan Lender <Stefan.Lender@dataport.de> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a52d284 to
c43fa09
Compare
hefftich
changed the title
|
Thanks @artonge, that makes sense! I've switched this over to the existing Reference/Smart Picker widget API. Teams now just resolves the resource URL and renders the registered widget in interactive mode — no Deck-specific rendering anymore, and other apps can use the same path. The Deck fixes needed for embedding and cleanup are in nextcloud/deck#8575, so we no longer need the separate web component. One thing we lose with the existing API is card-level URLs and syncing navigation inside the widget with browser history, since the API doesn't expose that state. Could you have another look and see if this is closer to what you had in mind? |
| const orderSettled = resources.orderChecked || resources.orderError | ||
| const pagesSettled = resources.pagesChecked || resources.pagesError || resources.folderError | ||
| return orderSettled && pagesSettled | ||
| return orderSettled && pagesSettled && resources.boardsChecked |
There was a problem hiding this comment.
resources.boardsChecked, is an explicit reference to Deck. If we want to link more than Deck boards to teams it needs to be agnostic. I know this is from before this PR, but we should also pave the way toward more resources :).
| label: board.title, | ||
| iconSvg: deckIcon, | ||
| href: board.url, | ||
| to: teamResourceRoute(teamId.value, 'deck', board.id), |
There was a problem hiding this comment.
Another explicit reference, let's try to find a way without :)
Resolves:
Display the team Deck boards within the Teams app #2948
Requires:
Handle embedded board lifecycles deck#8575
Summary
Display shared resources directly within Teams while preserving the active team context, using Nextcloud's existing Reference/Smart Picker widget API.
Teams resolves the selected resource URL through the reference API and renders its registered widget with
interactive: true. Other apps can participate through the same API without a new app-specific Teams adapter.Resource integration
RenderReferenceEvent.Deck support
Deck boards use the existing
deck-boardreference widget.nextcloud/deck#8575 provides the corresponding Deck-side fixes for embedded operation and cleanup of widget instances, board sessions, and Text editors.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)