Skip to content

fix(perf): don't enable qlog feature in perf binary - #850

Open
Frando wants to merge 4 commits into
mainfrom
Frando/perf-qlog
Open

Frando wants to merge 4 commits into
mainfrom
Frando/perf-qlog

Conversation

@Frando

@Frando Frando commented Oct 15, 2026

Copy link
Copy Markdown
Member

Description

We shouldn't enable the qlog feature for our perf binary by default. qlog slows things down considerably, and it shouldn't be on by default for a perf-measuring tool.

Change checklist

  • Self-review.

@Frando
Frando requested a review from flub October 15, 2026 12:00
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/850/docs/noq/

Last updated: 2026-10-29T10:53:18Z

@n0bot n0bot Bot added this to iroh Oct 15, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh Oct 15, 2026
@flub

flub commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

will need doc fixes. the noq rustls fixes are coming...

@matheus23

Copy link
Copy Markdown
Member

Should this PR name be prefixed fix(perf):, because it's about the perf crate?

@flub flub changed the title perf: don't enable qlog feature in perf binary fix(perf): don't enable qlog feature in perf binary Oct 15, 2026
@matheus23
matheus23 enabled auto-merge October 22, 2026 10:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚑 Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants