Skip to content

fix(rollout): accept HTTP sampler responses - #393

Merged
meichangsu1 merged 1 commit into
modelscope:dev-swift-v5from
werwrewe:fix/cs-grpo-rollout-response
Nov 18, 2026
Merged

meichangsu1 merged 1 commit into
modelscope:dev-swift-v5from
werwrewe:fix/cs-grpo-rollout-response

Conversation

@werwrewe

Copy link
Copy Markdown
Contributor

Convert the sampled sequence at the rollout boundary while preserving the HTTP sampler response contract.

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Twinkle 的 HTTP sampler 返回 SampleResponseModel,但 rollout 当时只接受本地 SampleResponse。修复放在 rollout 取序列的位置,让它能读取远程结果,同时保留 HTTP sampler 的返回类型。

具体报错信息:

File "/source/twinkle/src/twinkle_agentic/rollout/multi_turn.py", line 135, in _single_sequence
    raise TypeError(f'expected SampleResponse from sampler.sample, got {type(response).__name__}')
TypeError: expected SampleResponse from sampler.sample, got SampleResponseModel

Convert the sampled sequence at the rollout boundary while preserving the HTTP sampler response contract.
@meichangsu1
meichangsu1 merged commit 15f057a into modelscope:dev-swift-v5 Nov 18, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants