Repository navigation
fix(server): preserve task loaders and checkpoint resume state - #387
Merged
tastelikefeet merged 18 commits intoNov 17, 2026
Merged
Conversation
Keep task heads, optimizer state and deterministic continuation aligned across PPU training and cold resume.
Validate model families before allocation and carry custom components, task heads and encoded tensors through the HTTP training path.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Yunnglin
marked this pull request as ready for review
November 16, 2026 10:48
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Preserve lazy optimizer state across cold resume, reject incomplete saves before weight collection, and align Megatron checkpoint calls with supported APIs. Remove unverified decision handling and unrelated loader changes while tightening torch configuration validation.
hjh0119
approved these changes
Nov 17, 2026
|
|
||
| for module in self.model.modules(): | ||
| if type(module).__name__ == 'Qwen3_5GatedDeltaNet': | ||
| module.chunk_gated_delta_rule = torch_chunk_gated_delta_rule |
Collaborator
Author
There was a problem hiding this comment.
已回退相关代码,原本用于断点续训数值对照时切换 GDN 计算实现,但没有独立证据证明它是恢复问题的必要修复。
| return super()._task_head_state(adapter_name) | ||
|
|
||
| def _restore_task_head_state(self, adapter_name, state) -> None: | ||
| head = self._attached_head(adapter_name) |
Collaborator
Author
There was a problem hiding this comment.
已回退相关代码,任务头沿用已有保存恢复流程
tastelikefeet
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复服务端任务模型加载、租户任务头与训练状态隔离、断点恢复,以及多模态 LoRA 目标选择和 Megatron 多槽位一致性。