Repository navigation
Disable tab drag drop when running as a different user - #20798
Clint Dovholuk (dovholuknf) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This comment has been minimized.
This comment has been minimized.
8830342 to
1928c84
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
|
I know this one is stacked on the other one, but we may as well try to run the CI for the combination ;P |
other pr was green, this pr had analysis failures. I pushed a new commit faab979 to add suppressions but I don't know if you want that or something else? |
|
Dustin L. Howett (@DHowett) sorry but i'm gonna bump you on this just cause you were looking at it and i'd love to close these two prs out... |
|
this one will need a rebase, probably! I may also have some work to do on the |
one rebase coming right up while you contemplate :D |
faab979 to
b551215
Compare
|
rebase complete |
|
Dustin L. Howett (@DHowett) - checking back in on this. :) cheers |
disable drag/drop/tear when running as other users
Summary of the Pull Request
References and Relevant Issues
#15689
depends on #20394 many of the changes here are also on that PR. I can't "stack" from my fork here
Detailed Description of the Pull Request / Additional comments
When running
wt.exeas a different user, it's super easy to try to move the window but instead grab a tab anddrag... However when you do that,
wt.execrashes taking down not just the tab but all windows and all tabs withit. That is super frustrating. This PR disables drag/drop entirely for '/runas' users. the "move tab left/right"
still work
#20394 (comment) -
wtsapi32.libis now linked by every project (via src/common.build.post.props) as of this PR because I know of no better way to do it yet.Validation Steps Performed
PR Checklist
REPRODUCTION

FIX/ENHANCEMENT DEMONSTRATED
