Skip to content

[0.85] Route npm, Yarn, and NuGet restores through PackageFeedProxy - #16502

Merged
Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:0.85-stablefrom
vmoroz:fix/0.85-nuget-package-feed-proxy
Oct 24, 2026
Merged

Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:0.85-stablefrom
vmoroz:fix/0.85-nuget-package-feed-proxy

Conversation

@vmoroz

@vmoroz Vladimir Morozov (vmoroz) commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update
  • Automation (AI changes or Github Actions to reduce effort of manual tasks)

Why

Apply the anonymous npm/Yarn restore behavior from #16480 to 0.85, and use PackageFeedProxy for NuGet.org dependencies. Preserve the ADO-only V8 packages required by existing builds.

Related: #16480.

What

  • Package restores: route npm/npx, Yarn, and NuGet.org requests through PackageFeedProxy so isolated validation does not depend on feed credentials.
  • V8 compatibility: restrict ADO to the V8 package families and reuse the root NuGet policy in CI, preserving local test feeds and internal SDK opt-in.
  • Release safety: leave publishing destinations, authenticated feed maintenance, generated-project defaults, and dependency versions unchanged.

Screenshots

Not applicable; package-feed configuration only.

Testing

  • npm view is-number@7.0.0 version --json, npx --yes --package=@react-native-community/cli@20.2.0 rnc-cli --version, and yarn install --mode=skip-build: passed in isolated proxy fixtures.
  • Combined NuGet validation: 939 assertions passed, including all 25 locked versions on 0.85. Edited YAML formatting and git diff --check: passed.
  • Full local Yarn quality commands are blocked by missing workspace dependencies.

Optional: Azure PR validation 632098: passed (30 jobs, including all six CLI-init app/library jobs). Native builds were not run locally.

Changelog

Should this change be included in the release notes: no

Use PackageFeedProxy for package restores while preserving ADO-only V8 packages.

Microsoft Reviewers: Open in CodeFlow

Keep ADO-only V8 packages on their mapped feed and preserve publication destinations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 24, 2026 00:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Cross-cutting restore and source-mapping changes still need successful native and CLI-init pipeline validation before final human approval.

1 open issue
What changed in this PR

This PR backports anonymous package restores to 0.85, routing repository and CI dependencies through PackageFeedProxy while retaining ADO-only V8 packages and existing publishing destinations.

Changes:

  • Route npm, Yarn, NuGet.org, and BinSkim restores through PackageFeedProxy.
  • Reuse root NuGet source mappings in CI while preserving local test feeds and internal SDK opt-in.
  • Update authentication handling and package-feed documentation.
File Description
vnext/​Scripts/​NuGetRestoreForceEvaluateAllSolutions.ps1 Update comments to describe the approved source policy.
vnext/​Scripts/​EnableInternalWinAppSDKFeed.ps1 Add source mapping when enabling the internal SDK feed.
NuGet.Config Add the proxy and restrict ADO mappings to V8 packages.
change/​react-native-windows-9c991519-fc65-4a2d-b61e-466a628c8115.json Record the restore-routing change.
.ado/​variables/​shared.yml Point npm and Yarn at the anonymous proxy.
.ado/​templates/​react-native-init-windows.yml Import root NuGet policy and retain the local test feed.
.ado/​templates/​prepare-js-env.yml Clarify the authentication step’s purpose in a comment.
.ado/​templates/​prepare-build-env.yml Require NuGet 6+ and apply root policy to third-party configs.
.ado/​templates/​auth-npm-feed.yml Stop writing global Yarn credentials while retaining npm authentication.
.ado/​scripts/​build.js Download BinSkim through the proxy.
.ado/​README.md Document restore routing, authentication, and retained endpoints.
.ado/​build-template.yml Clarify the feed-token comment and remove trailing whitespace.

Review effort: Balanced

Comment thread NuGet.Config Resolved
Direct local internal SDK testing through the helper that adds both the NuGet source and its package mapping.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 24, 2026 01:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The repository-wide restore-policy migration needs successful isolated Windows native and CLI-init CI validation before final human approval.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) requested a balanced review from Copilot October 24, 2026 01:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The shared restore-policy changes still need end-to-end confirmation for native and generated-project builds in network-isolated CI.

No open issues 🎉

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit 9a2d830 into microsoft:0.85-stable Oct 24, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants