Skip to content

Route npm, Yarn, and NuGet restores through PackageFeedProxy - #16501

Merged
Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:mainfrom
vmoroz:fix/nuget-package-feed-proxy
Oct 24, 2026
Merged

Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:mainfrom
vmoroz:fix/nuget-package-feed-proxy

Conversation

@vmoroz

@vmoroz Vladimir Morozov (vmoroz) commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update
  • Automation (AI changes or Github Actions to reduce effort of manual tasks)

Why

Use anonymous PackageFeedProxy restores consistently in PR and Continuous validation, following #16480. Keep ADO-only V8 packages available without retaining a general ADO fallback.

Related: #16480.

What

  • Package restores: keep npm/npx and Yarn on the proxy after CI authentication, and route NuGet.org dependencies through its NuGet V3 endpoint.
  • V8 compatibility: map only the V8 package families to ADO. Reuse the root NuGet policy in CI while preserving local test feeds and internal SDK opt-in.
  • Release safety: leave publishing destinations, authenticated feed maintenance, generated-project defaults, and dependency versions unchanged.

Screenshots

Not applicable; package-feed configuration only.

Testing

  • npm view is-number@7.0.0 version --json, npx --yes --package=@react-native-community/cli@20.2.0 rnc-cli --version, and yarn install --mode=skip-build: passed in isolated proxy fixtures.
  • NuGet configuration/restore checks: 939 assertions passed, including source isolation and lockfile content hashes. Edited YAML formatting passed.
  • git diff --check: passed. yarn lint:fix: blocked locally by missing @react-native/jest-preset/package.json.

Optional: Azure PR validation 632097: passed (30 jobs, including all six CLI-init app/library jobs). Native builds were not run locally.

Changelog

Should this change be included in the release notes: no

Use PackageFeedProxy for package restores while preserving ADO-only V8 packages.

Microsoft Reviewers: Open in CodeFlow

Keep ADO-only V8 packages on their mapped feed and preserve publication destinations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 24, 2026 00:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Repository-wide restore routing still needs native and CLI-init validation under network-isolated CI, and manual internal-SDK opt-in guidance remains inconsistent.

1 open issue
What changed in this PR

Routes repository and validation restores through PackageFeedProxy while retaining restricted V8 access through Azure Artifacts and preserving publishing destinations.

Changes:

  • Keeps npm and Yarn on the anonymous proxy after CI authentication.
  • Adds NuGet source mappings and reuses them in CI and internal-SDK setup.
  • Updates feed-policy documentation and release metadata.
File Description
vnext/​Scripts/​NuGetRestoreForceEvaluateAllSolutions.ps1 Updates comments to describe the approved source policy.
vnext/​Scripts/​EnableInternalWinAppSDKFeed.ps1 Adds a mapping when enabling the internal SDK feed.
NuGet.Config Routes general packages through the proxy and V8 families through ADO.
change/​react-native-windows-9f0d8341-df43-4ae9-9523-3bc3f8b5df44.json Records the restore-routing change.
.ado/​warm-feed-pipeline.yml Clarifies bootstrap and feed-maintenance comments.
.ado/​variables/​shared.yml Documents anonymous npm and Yarn routing.
.ado/​templates/​react-native-init-windows.yml Imports repository NuGet policy while retaining the local test feed.
.ado/​templates/​prepare-js-env.yml Clarifies the authentication step’s purpose.
.ado/​templates/​prepare-build-env.yml Requires NuGet 6+ and applies repository policy to third-party configs.
.ado/​templates/​auth-npm-feed.yml Stops authentication from overriding proxy registry settings.
.ado/​scripts/​build.js Downloads BinSkim through the NuGet proxy.
.ado/​README.md Documents restore routing and retained feed exceptions.
.ado/​build-template.yml Updates the authentication comment and removes trailing whitespace.

Review effort: Balanced

Comment thread NuGet.Config Resolved
Direct local internal SDK testing through the helper that adds both the NuGet source and its package mapping.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 24, 2026 01:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The cross-cutting restore-policy changes need successful Windows native-build and CLI-init validation before final human approval.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Repository-wide restore and authentication changes need successful Windows native-build and CLI-init CI validation before final human approval.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit b7001f1 into microsoft:main Oct 24, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants