[Duckki Oe (duckki)]

Description

Buffered quicforward receives coalesce their input into one outgoing buffer.
Use that outgoing descriptor count for StreamSend instead of the original
receive count. Unbuffered forwarding retains the original count.

Testing

Added quicforward_send_test under src/tools/forwarder/test for a two-buffer receive.
It checks the combined bytes and count in buffered mode, and the original
descriptors and count in unbuffered mode. It passes through CTest with
QUIC_BUILD_TEST=ON and QUIC_BUILD_TOOLS=ON, and in a direct ASan/UBSan run.
A local 24 KiB forwarder probe also kept both modes live.

Documentation

No documentation changes.

[Duckki Oe (duckki)]

@microsoft-github-policy-service agree

[Guillaume Hetier (guhetier)]

This doesn't belong here.
If you want to add test for the forwarder sample, have them in a subfolder of the forwarder sample.
They do not belong in MsQuic product code.

[Duckki Oe (duckki)]

Moved it under src/tools/forwarder/test.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.90%. Comparing base (f2ab314) to head (9c454dd).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6444      +/-   ##
==========================================
- Coverage   88.68%   87.90%   -0.78%     
==========================================
  Files          60       60              
  Lines       19096    19096              
==========================================
- Hits        16935    16787     -148     
- Misses       2161     2309     +148     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zerox80]

isn't that btw a case for MSRC instead of public PR?

[Guillaume Hetier (guhetier)]

isn't that btw a case for MSRC instead of public PR?

If you ever have doubts, please file an MSRC case and do not open an issue / PR on GitHub.
In this case, the issue is with a sample/test tool, not product code, so we would not treat it as a security issue.

[zerox80]

isn't that btw a case for MSRC instead of public PR?

If you ever have doubts, please file an MSRC case and do not open an issue / PR on GitHub. In this case, the issue is with a sample/test tool, not product code, so we would not treat it as a security issue.

Thanks for clarifying. I reported the same issue to MSRC on October 18 (case #166943), including a working PoC and root cause analysis.

I only noticed this PR afterward. I'll follow up with MSRC about my earlier report and researcher credit

[Guillaume Hetier (guhetier)]

If adding unit tests for this sample code, please use gtest and add them to CI runs. Test code that doesn't run is not useful.
I don't think it is useful to add this test though: sample are already test/demonstration code.

[Duckki Oe (duckki)]

Ok, I just simplified to one-liner fix without test.