Share complete union and intersection property cache entries by jakebailey · Pull Request #64789 · microsoft/TypeScript

Jake Bailey (jakebailey) · 2026-10-13T17:37:00Z

Complete non-augmented property results are also valid for augmented lookups, but were copied into both caches. MUI keeps 2.7M duplicate entries this way.

Shares complete entries between the two lookup modes without merging genuinely different results.
MUI measurements showed 8.15% less retained heap, 9.22% less GC scanning, and 4.45% fewer allocated bytes; the production CLI ran 2.60% fewer instructions.
VS Code savings were much smaller.

Copilot

🟡 Changes recommended

Augmented-first synthetic property lookups still retain duplicate entries because independently created symbols fail the pointer-identity check.

1 open finding

Augmented-first lookup leaves duplicate cache entries · New

What changed in this PR

Optimizes union/intersection property caching to reduce duplicate retained symbols.

Changes:

Reuses complete non-augmented cache entries.
Preserves distinct augmented results.
Adds cache-sharing and function-augmentation tests.

File	Description
`tsc/internal/checker/checker.go`	Implements cache sharing and cleanup.
`tsc/internal/checker/types.go`	Documents cache semantics.
`tsc/internal/checker/types_test.go`	Tests cache modes and sharing.
`tsc/internal/checker/checker_test.go`	Tests function-property augmentation behavior.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟢 Approval recommended

The cache precedence remains correct, and focused tests cover lookup ordering, partial entries, and function augmentation.

0 open findings

1 resolved since last review

Augmented-first lookup leaves duplicate cache entries

🧠 Review effort: Balanced

Complete non-augmented properties are valid for augmented lookup, but copying each result into both caches retains duplicate name tables. MUI keeps 2,734,919 identical entries this way, nearly doubling its union/intersection cache storage without adding semantic information. Preserve independent augmented results and partial-property behavior while sharing complete entries. A failed lookup needs no empty table. The MUI census falls from 230242 tables and 5628201 entries to 116635 tables and 2893282 entries; all distinct cached identities remain. Six fresh-process interleaved single-checker comparisons against the parent commit, with ordinary GC, save 135.63 MiB of retained MUI heap (-8.15%) and 132.00 MiB of GC scanning (-9.22%). Total allocated bytes fall 4.45% and allocation events fall 1.46%. VS Code's corresponding reductions are small: retained -0.15%, scan -0.17%, allocated -0.16%. Instruction differences in these single-checker comparisons are inconclusive; elapsed time is noisy on the shared machine. Six default-threaded production CLI pairs confirm MUI's reported heap falls 9.29% and instructions fall 2.60%. VS Code and Webpack have small heap reductions and inconclusive instruction differences. These are incremental savings on top of the earlier branch optimizations. CLI-reported heap is not the forced-GC retained-heap measure above. MUI uses the CI-pinned source and restored scenario dependencies at 6780195595c12252a130aa5ae5c5bd461229c6b7. VS Code uses 8bf178e1e1c2be3723f14683f7b1e5fdb3f780e4. Webpack uses an isolated 2289141381f2c1c965cb65118fa0ffe2e9e19834 with restored dependencies. Production diagnostics and all semantic counts match exactly. Tests cover both query orders, both composite kinds, cache growth and GC reachability, missing entries, read/write partial flags, differing mode-specific identities, and real function-property augmentation. The storage regressions fail before this change. Single-checker retained heap and allocation measurements: │ mui-shared-union-before.txt │ mui-shared-union-shared.txt │ │ retained-B │ retained-B vs base │ ExternalMemory-20 1.624Gi ± 0% 1.492Gi ± 0% -8.15% (p=0.002 n=6) │ mui-shared-union-before.txt │ mui-shared-union-shared.txt │ │ scan-B │ scan-B vs base │ ExternalMemory-20 1.398Gi ± 0% 1.270Gi ± 0% -9.22% (p=0.002 n=6) │ mui-shared-union-before.txt │ mui-shared-union-shared.txt │ │ B/op │ B/op vs base │ ExternalMemory-20 5.364Gi ± 0% 5.125Gi ± 0% -4.45% (p=0.002 n=6) │ mui-shared-union-before.txt │ mui-shared-union-shared.txt │ │ allocs/op │ allocs/op vs base │ ExternalMemory-20 25.17M ± 0% 24.80M ± 1% -1.46% (p=0.002 n=6) │ vscode-shared-union-before.txt │ vscode-shared-union-shared.txt │ │ retained-B │ retained-B vs base │ ExternalMemory-20 2.619Gi ± 0% 2.615Gi ± 0% -0.15% (p=0.002 n=6) │ vscode-shared-union-before.txt │ vscode-shared-union-shared.txt │ │ scan-B │ scan-B vs base │ ExternalMemory-20 2.291Gi ± 0% 2.287Gi ± 0% -0.17% (p=0.002 n=6) │ vscode-shared-union-before.txt │ vscode-shared-union-shared.txt │ │ B/op │ B/op vs base │ ExternalMemory-20 3.754Gi ± 0% 3.748Gi ± 0% -0.16% (p=0.002 n=6) │ vscode-shared-union-before.txt │ vscode-shared-union-shared.txt │ │ allocs/op │ allocs/op vs base │ ExternalMemory-20 23.61M ± 0% 23.59M ± 0% -0.08% (p=0.002 n=6) Single-checker instructions: │ mui-shared-union-before.instructions │ mui-shared-union-shared.instructions │ │ instructions/op │ instructions/op vs base │ ExternalInstructions-20 218.9G ± 3% 217.3G ± 2% ~ (p=0.310 n=6) │ vscode-shared-union-before.instructions │ vscode-shared-union-shared.instructions │ │ instructions/op │ instructions/op vs base │ ExternalInstructions-20 188.8G ± 3% 192.1G ± 2% ~ (p=0.394 n=6) Default-threaded production CLI: │ shared-union-cli-before.txt │ shared-union-cli-after.txt │ │ instructions/op │ instructions/op vs base │ mui-20 283.3G ± 1% 275.9G ± 2% -2.60% (p=0.015 n=6) vscode-20 308.2G ± 7% 293.0G ± 6% ~ (p=0.818 n=6) webpack-20 51.96G ± 5% 51.82G ± 4% ~ (p=1.000 n=6) geomean 165.6G 161.2G -2.62% │ shared-union-cli-before.txt │ shared-union-cli-after.txt │ │ heap-B/op │ heap-B/op vs base │ mui-20 2.059Gi ± 0% 1.868Gi ± 0% -9.29% (p=0.002 n=6) vscode-20 2.835Gi ± 0% 2.829Gi ± 0% -0.21% (p=0.004 n=6) webpack-20 666.9Mi ± 0% 663.0Mi ± 0% -0.57% (p=0.002 n=6) geomean 1.561Gi 1.507Gi -3.45% │ shared-union-cli-before.txt │ shared-union-cli-after.txt │ │ allocs/op │ allocs/op vs base │ mui-20 29.84M ± 0% 29.55M ± 0% -0.97% (p=0.002 n=6) vscode-20 36.67M ± 2% 36.64M ± 0% ~ (p=0.132 n=6) webpack-20 6.235M ± 2% 6.208M ± 0% -0.43% (p=0.002 n=6) geomean 18.97M 18.87M -0.49% │ shared-union-cli-before.txt │ shared-union-cli-after.txt │ │ check-sec/op │ check-sec/op vs base │ mui-20 8.986 ± 6% 8.559 ± 4% -4.75% (p=0.026 n=6) vscode-20 8.345 ± 4% 8.900 ± 10% ~ (p=0.132 n=6) webpack-20 1.851 ± 8% 1.818 ± 8% ~ (p=0.310 n=6) geomean 5.178 5.173 -0.08%

Jake Bailey (jakebailey) · 2026-10-14T17:13:36Z

TypeScript Bot (@typescript-bot) perf test this faster

typescript-automation · 2026-10-14T17:13:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-automation · 2026-10-14T17:57:48Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_115,276	_115,276	_~	_~	_~	_{p=1.000 n=12}
_Types	_79,613	_79,613	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{113,501k (± 0.08%)}	_{113,280k (± 0.06%)}	_{-221k (- 0.19%)}	_113,135k	_113,464k	_{p=0.000 n=12}
_{Memory Allocs}	_{2,212,423 (± 0.00%)}	_{2,211,013 (± 0.00%)}	_{-1,410 (- 0.06%)}	_2,210,785	_2,211,406	_{p=0.000 n=12}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.040s (± 4.11%)}	_{0.040s (± 2.07%)}	_~	_0.038s	_0.042s	_{p=0.900 n=12}
_{Bind Time}	_{0.014s (± 8.40%)}	_{0.014s (±10.53%)}	_~	_0.011s	_0.017s	_{p=0.798 n=12}
_{Check Time}	_{0.482s (± 0.96%)}	_{0.481s (± 0.77%)}	_~	_0.474s	_0.494s	_{p=0.987 n=12}
_{Emit Time}	_{0.268s (± 2.24%)}	_{0.265s (± 2.49%)}	_~	_0.246s	_0.279s	_{p=0.451 n=12}
_{Total Time}	_{0.810s (± 0.63%)}	_{0.806s (± 0.74%)}	_~	_0.787s	_0.820s	_{p=0.434 n=12}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_{847,454 (± 0.10%)}	_{847,179 (± 0.05%)}	_~	_845,788	_848,066	_{p=0.266 n=12}
_Types	_{247,032 (± 0.00%)}	_{247,033 (± 0.00%)}	_~	_247,030	_247,040	_{p=0.361 n=12}
_{Memory Used}	_{596,390k (± 0.03%)}	_{595,780k (± 0.03%)}	_{-609k (- 0.10%)}	_595,363k	_596,136k	_{p=0.000 n=12}
_{Memory Allocs}	_{13,142,796 (± 0.05%)}	_{13,141,858 (± 0.06%)}	_~	_13,131,740	_13,173,663	_{p=0.799 n=12}
_{Config Time}	_0.020s	_0.020s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.283s (± 3.40%)}	_{0.288s (± 3.37%)}	_~	_0.266s	_0.314s	_{p=0.401 n=12}
_{Bind Time}	_{0.101s (±17.32%)}	_{0.092s (±12.41%)}	_~	_0.072s	_0.126s	_{p=0.560 n=12}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=12}
_{Emit Time}	_{1.865s (± 1.67%)}	_{1.867s (± 2.34%)}	_~	_1.750s	_1.981s	_{p=0.966 n=12}
_{Total Time}	_{2.286s (± 1.49%)}	_{2.286s (± 1.88%)}	_~	_2.161s	_2.391s	_{p=0.876 n=12}
_{mui-docs - native}
_Errors	_11,405	_11,405	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_4,331,835	_4,331,835	_~	_~	_~	_{p=1.000 n=12}
_Types	_1,370,520	_1,370,520	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{2,625,578k (± 0.08%)}	_{2,422,955k (± 0.07%)}	_{🟩-202,622k (- 7.72%)}	_2,419,928k	_2,428,862k	_{p=0.000 n=12}
_{Memory Allocs}	_{27,712,648 (± 0.09%)}	_{27,401,077 (± 0.07%)}	_{-311,571 (- 1.12%)}	_27,350,394	_27,460,086	_{p=0.000 n=12}
_{Config Time}	_{0.020s (± 1.52%)}	_0.020s	_~	_~	_~	_{p=0.093 n=12}
_{Parse Time}	_{0.592s (± 2.71%)}	_{0.575s (± 2.29%)}	_~	_0.552s	_0.613s	_{p=0.071 n=12}
_{Bind Time}	_{0.002s (±13.27%)}	_{0.003s (±12.54%)}	_~	_0.002s	_0.003s	_{p=0.414 n=12}
_{Check Time}	_{8.726s (± 0.59%)}	_{8.353s (± 0.44%)}	_{🟩-0.373s (- 4.27%)}	_8.272s	_8.436s	_{p=0.000 n=12}
_{Emit Time}	_{0.592s (±12.74%)}	_{0.604s (± 8.83%)}	_~	_0.501s	_0.767s	_{p=0.486 n=12}
_{Total Time}	_{10.835s (± 0.83%)}	_{10.479s (± 0.91%)}	_{🟩-0.357s (- 3.29%)}	_10.303s	_10.768s	_{p=0.000 n=12}
_{strada-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,388,669	_1,388,669	_~	_~	_~	_{p=1.000 n=12}
_Types	_441,862	_441,862	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{1,315,128k (± 0.95%)}	_{1,313,808k (± 0.69%)}	_~	_1,292,955k	_1,335,049k	_{p=0.843 n=12}
_{Memory Allocs}	_{78,239,017 (± 0.08%)}	_{78,075,485 (± 0.09%)}	_{-163,533 (- 0.21%)}	_77,821,877	_78,225,298	_{p=0.001 n=12}
_{Config Time}	_{0.004s (±11.30%)}	_{0.005s (± 7.07%)}	_~	_0.004s	_0.005s	_{p=0.574 n=12}
_{Parse Time}	_{0.313s (± 2.19%)}	_{0.306s (± 1.72%)}	_~	_0.293s	_0.318s	_{p=0.097 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{2.116s (± 0.61%)}	_{2.110s (± 0.66%)}	_~	_2.065s	_2.145s	_{p=0.681 n=12}
_{Emit Time}	_{0.344s (± 4.50%)}	_{0.362s (± 5.18%)}	_~	_0.315s	_0.413s	_{p=0.156 n=12}
_{Total Time}	_{24.921s (± 0.56%)}	_{24.917s (± 0.50%)}	_~	_24.551s	_25.328s	_{p=0.671 n=12}
_{strada-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_334,953	_334,953	_~	_~	_~	_{p=1.000 n=12}
_Types	_197,616	_197,616	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{247,500k (± 0.03%)}	_{246,203k (± 0.03%)}	_{-1,297k (- 0.52%)}	_245,912k	_246,376k	_{p=0.000 n=12}
_{Memory Allocs}	_{4,329,624 (± 0.01%)}	_{4,319,049 (± 0.01%)}	_{-10,575 (- 0.24%)}	_4,317,500	_4,319,925	_{p=0.000 n=12}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.113s (± 4.35%)}	_{0.115s (± 5.29%)}	_~	_0.104s	_0.133s	_{p=0.744 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{1.004s (± 0.61%)}	_{1.005s (± 0.56%)}	_~	_0.991s	_1.018s	_{p=0.766 n=12}
_{Emit Time}	_{0.148s (± 4.81%)}	_{0.146s (± 6.55%)}	_~	_0.126s	_0.174s	_{p=0.486 n=12}
_{Total Time}	_{1.319s (± 0.79%)}	_{1.318s (± 0.77%)}	_~	_1.295s	_1.353s	_{p=0.788 n=12}
_{ts-pre-modules - native}
_Errors	₈₇	₈₇	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_303,834	_303,834	_~	_~	_~	_{p=1.000 n=12}
_Types	_181,663	_181,663	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{215,249k (± 0.02%)}	_{214,377k (± 0.02%)}	_{-873k (- 0.41%)}	_214,244k	_214,499k	_{p=0.000 n=12}
_{Memory Allocs}	_{1,401,743 (± 0.02%)}	_{1,394,911 (± 0.02%)}	_{-6,832 (- 0.49%)}	_1,394,178	_1,395,596	_{p=0.000 n=12}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.079s (± 4.20%)}	_{0.077s (± 4.70%)}	_~	_0.069s	_0.087s	_{p=0.270 n=12}
_{Bind Time}	_{0.033s (±10.75%)}	_{0.033s (±10.32%)}	_~	_0.026s	_0.042s	_{p=0.920 n=12}
_{Check Time}	_{0.653s (± 0.89%)}	_{0.660s (± 0.81%)}	_~	_0.648s	_0.672s	_{p=0.109 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{0.779s (± 0.54%)}	_{0.782s (± 0.43%)}	_~	_0.772s	_0.788s	_{p=0.192 n=12}
_{vscode - native}
_Errors	₃₉₆	₃₉₆	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_11,687,315	_11,687,315	_~	_~	_~	_{p=1.000 n=12}
_Types	_3,851,234	_3,851,234	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{5,514,223k (± 0.01%)}	_{5,507,186k (± 0.02%)}	_{-7,037k (- 0.13%)}	_5,505,242k	_5,512,205k	_{p=0.000 n=12}
_{Memory Allocs}	_{56,194,559 (± 0.02%)}	_{56,156,475 (± 0.02%)}	_{-38,084 (- 0.07%)}	_56,143,430	_56,196,869	_{p=0.000 n=12}
_{Config Time}	_{0.075s (± 0.24%)}	_{0.075s (± 0.24%)}	_~	_0.075s	_0.076s	_{p=1.000 n=12}
_{Parse Time}	_{1.762s (± 2.02%)}	_{1.761s (± 2.17%)}	_~	_1.665s	_1.878s	_{p=0.887 n=12}
_{Bind Time}	_{0.603s (±11.75%)}	_{0.619s (±14.40%)}	_~	_0.478s	_0.898s	_{p=0.854 n=12}
_{Check Time}	_{13.425s (± 0.96%)}	_{13.383s (± 1.03%)}	_~	_13.106s	_13.657s	_{p=0.291 n=12}
_{Emit Time}	_{5.429s (± 7.22%)}	_{5.300s (± 8.14%)}	_~	_4.327s	_6.108s	_{p=0.799 n=12}
_{Total Time}	_{21.387s (± 1.51%)}	_{21.226s (± 1.69%)}	_~	_20.452s	_21.987s	_{p=0.452 n=12}
_{webpack - native}
_Errors	₅₈₄	₅₈₄	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,299,351	_1,299,351	_~	_~	_~	_{p=1.000 n=12}
_Types	_598,360	_598,360	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{789,567k (± 0.02%)}	_{785,500k (± 0.03%)}	_{-4,067k (- 0.52%)}	_785,013k	_786,046k	_{p=0.000 n=12}
_{Memory Allocs}	_{6,053,271 (± 0.03%)}	_{6,026,225 (± 0.01%)}	_{-27,046 (- 0.45%)}	_6,024,442	_6,029,479	_{p=0.000 n=12}
_{Config Time}	_{0.007s (± 4.37%)}	_{0.007s (± 3.92%)}	_~	_0.007s	_0.008s	_{p=0.667 n=12}
_{Parse Time}	_{0.237s (± 2.62%)}	_{0.237s (± 3.01%)}	_~	_0.226s	_0.257s	_{p=0.468 n=12}
_{Bind Time}	_{0.056s (± 2.02%)}	_{0.061s (±10.68%)}	_{🔻+0.005s (+ 9.31%)}	_0.054s	_0.090s	_{p=0.049 n=12}
_{Check Time}	_{1.641s (± 0.53%)}	_{1.631s (± 0.59%)}	_~	_1.597s	_1.650s	_{p=0.070 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{1.970s (± 0.47%)}	_{1.966s (± 0.60%)}	_~	_1.938s	_1.993s	_{p=0.832 n=12}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,062,854	_1,062,854	_~	_~	_~	_{p=1.000 n=12}
_Types	_390,845	_390,845	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{472,296k (± 0.03%)}	_{468,642k (± 0.02%)}	_{-3,654k (- 0.77%)}	_468,341k	_468,823k	_{p=0.000 n=12}
_{Memory Allocs}	_{4,225,576 (± 0.08%)}	_{4,204,254 (± 0.03%)}	_{-21,322 (- 0.50%)}	_4,199,305	_4,208,047	_{p=0.000 n=12}
_{Config Time}	_0.003s	_0.003s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.135s (± 3.34%)}	_{0.136s (± 2.71%)}	_~	_0.129s	_0.148s	_{p=0.485 n=12}
_{Bind Time}	_{0.047s (±13.74%)}	_{0.045s (±12.39%)}	_~	_0.035s	_0.065s	_{p=0.598 n=12}
_{Check Time}	_{1.009s (± 0.69%)}	_{0.999s (± 0.89%)}	_{-0.010s (- 1.00%)}	_0.978s	_1.030s	_{p=0.029 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{1.203s (± 0.65%)}	_{1.193s (± 0.88%)}	_~	_1.162s	_1.218s	_{p=0.203 n=12}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
mui-docs - native
strada-build-src - native
strada-compiler - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₁₂
_Baseline	_baseline	₁₂

Developer Information:

Download Benchmarks

Daniel Rosenwasser (DanielRosenwasser) · 2026-10-17T06:30:30Z

+				delete(data.propertyCache, name)
+				if len(data.propertyCache) == 0 {
+					data.propertyCache = nil
+				}


I'm not that familiar with this code path (I don't entirely know when you need one map but not the other), but I do wonder if you can hit a pathological case where you keep deleting/reallocating maps.

Also, I wonder if you can save anything by having one "steal" a map from the other if the size is just 1.

Daniel Rosenwasser (DanielRosenwasser) · 2026-10-17T06:31:37Z

 	assert.Equal(t, defaultClause, defaultReference)
 }

+func TestUnionPropertyFunctionAugmentation(t *testing.T) {


What about this test used to fail before?

typescript-automation Bot assigned Jake Bailey (jakebailey) Oct 13, 2026

typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 13, 2026

Jake Bailey (jakebailey) added this pull request to stack #64792 October 13, 2026 17:37

Jake Bailey (jakebailey) mentioned this pull request Oct 13, 2026

Various memory optimizations #64734

Closed

Jake Bailey (jakebailey) marked this pull request as ready for review October 13, 2026 17:42

Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:42

Copilot started reviewing on behalf of Jake Bailey (jakebailey) October 13, 2026 17:44

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Comment thread tsc/internal/checker/checker.go

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 98420cf to 46ffb18 Compare October 13, 2026 18:36

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 847d584 to 1807ffa Compare October 13, 2026 18:37

Jake Bailey (jakebailey) marked this pull request as draft October 13, 2026 19:41

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 1807ffa to a6efe11 Compare October 13, 2026 20:06

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 46ffb18 to 3b5631d Compare October 13, 2026 20:06

Jake Bailey (jakebailey) removed this pull request from stack #64792 October 13, 2026 20:15

Jake Bailey (jakebailey) added this pull request to stack #64805 October 13, 2026 20:16

Jake Bailey (jakebailey) removed this pull request from stack #64805 October 13, 2026 20:49

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from a6efe11 to 5b65d47 Compare October 13, 2026 20:50

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 3b5631d to 2b8f9af Compare October 13, 2026 20:50

Jake Bailey (jakebailey) added this pull request to stack #64806 October 13, 2026 20:50

Jake Bailey (jakebailey) requested a balanced review from Copilot October 13, 2026 21:12

Copilot started reviewing on behalf of Jake Bailey (jakebailey) October 13, 2026 21:13

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 2b8f9af to f7addbf Compare October 13, 2026 21:39

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 5b65d47 to a4f0e31 Compare October 13, 2026 21:39

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from f7addbf to 2a5167f Compare October 13, 2026 22:00

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from a4f0e31 to 9649222 Compare October 13, 2026 22:00

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 2a5167f to 51be58b Compare October 13, 2026 22:25

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 9649222 to 33f5302 Compare October 13, 2026 22:25

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 51be58b to f34f38a Compare October 13, 2026 23:08

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 33f5302 to 766660b Compare October 13, 2026 23:08

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from f34f38a to e59a4dd Compare October 13, 2026 23:16

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch 2 times, most recently from 5fea824 to f7bee08 Compare October 13, 2026 23:18

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from e59a4dd to a15ee39 Compare October 13, 2026 23:18

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch 2 times, most recently from 3782578 to 779852a Compare October 14, 2026 02:23

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch 2 times, most recently from 59c8a48 to ad1de82 Compare October 14, 2026 02:27

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 779852a to b9fa688 Compare October 14, 2026 02:27

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from ad1de82 to 354885c Compare October 14, 2026 03:47

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from b9fa688 to 0aaf90f Compare October 14, 2026 03:47

Anders Hejlsberg (ahejlsberg) force-pushed the jakebailey/mem/shared-property-cache branch from 0aaf90f to 1165604 Compare October 14, 2026 14:14

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 1165604 to 6aa42dc Compare October 14, 2026 14:17

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/exact-relation-keys branch from 0e30e19 to 8455c76 Compare October 14, 2026 14:17

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 6aa42dc to 7e29b1e Compare October 14, 2026 16:02

Jake Bailey (jakebailey) removed this pull request from stack #64806 October 14, 2026 16:55

Jake Bailey (jakebailey) changed the base branch from jakebailey/mem/exact-relation-keys to main October 14, 2026 16:56

Jake Bailey (jakebailey) force-pushed the jakebailey/mem/shared-property-cache branch from 7e29b1e to ee3bc6c Compare October 14, 2026 16:56

Jake Bailey (jakebailey) marked this pull request as ready for review October 14, 2026 16:58

Jake Bailey (jakebailey) requested a review from Anders Hejlsberg (ahejlsberg) October 14, 2026 17:22

Daniel Rosenwasser (DanielRosenwasser) reviewed Oct 17, 2026

View reviewed changes

Navigation Menu

Repository navigation

Share complete union and intersection property cache entries - #64789

Share complete union and intersection property cache entries#64789
Jake Bailey (jakebailey) wants to merge 1 commit into
mainfrom
jakebailey/mem/shared-property-cache

Jake Bailey (jakebailey) commented Oct 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Jake Bailey (jakebailey) commented Oct 14, 2026

Uh oh!

typescript-automation Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Oct 14, 2026

tsc

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) Oct 17, 2026

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) Oct 17, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Jake Bailey (jakebailey) commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Jake Bailey (jakebailey) commented Oct 14, 2026

Uh oh!

typescript-automation Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Oct 14, 2026

tsc

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jake Bailey (jakebailey) commented Oct 13, 2026 •

edited

Loading

typescript-automation Bot commented Oct 14, 2026 •

edited

Loading