Repository navigation
[Nexthop][bugfix] Fix race in ExpectSessionTest - #2000
Closed
andrew-nexthop wants to merge 1 commit into
Closed
andrew-nexthop wants to merge 1 commit into
andrew-nexthop wants to merge 1 commit into
Conversation
Poll isAlive() until the child is reaped instead of asserting once at EOF.
Contributor
Author
|
/autorebase |
Contributor
|
@somasun has imported this pull request. If you are a Meta employee, you can view this in D132399699. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
ExpectSessionTest.NoticesWhenChildExitsandExpectSessionTest.ChildReapedElsewhereIsNotAliveassert!isAlive()as soon as the session reaches EOF. The pty reports EOF when the child closes its terminal during exit, which can happen before the child is reapable, sowaitpid(WNOHANG)still returns 0 andisAlive()is briefly true. This madeNoticesWhenChildExitsflaky in our CI. The tests now pollisAlive()until the child has been reaped, bounded by the existing 10s timeout.Test Plan
Ran
ExpectSessionTestsuite repeatedly, before and after the fix, on an idle machine and with every CPU busy:NoticesWhenChildExitsChildReapedElsewhereIsNotAlive