Repository navigation
Conversation
| @@ -0,0 +1,48 @@ | |||
| /* | |||
There was a problem hiding this comment.
@prapty : Can you address the pre-commit action failure?
We recently enforced a new copyright header for any new cpp files. You can find out more from https://github.com/meta/fboss/actions/runs/43297841198/job/131460795732?pr=1969
a9e36aa to
7e8c2c8
Compare
|
@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D131864056. |
|
@joseph5wu merged this pull request in 531e673. |
|
Since this PR was originally prepared, Srv6Tunnel::underlayIntfID became optional to support decap tunnels without an underlay interface. We updated the PR to match the current schema: encap validation now checks that the optional has a value before dereferencing it, and the decap unit test verifies that the field is unset rather than expecting a default value of 0. The full config test suite passes with these updates. |
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Add
fboss2commands to create, update, and delete SRv6 encap and decap tunnel configuration through the standard FBOSS config session.The new commands validate tunnel identifiers and attributes, preserve unspecified fields during partial updates, prevent changing an existing tunnel between encap and decap, enforce the single-decap-tunnel constraint, and allow selected optional fields to be reset. SRv6 encap requires an existing underlay interface and an IPv6 source address; SRv6 decap does not use an underlay interface. Changes are staged in the agent configuration at the hitless action level and can be reviewed with
fboss2 config session diffbefore commit.Both BUCK and CMake build definitions are updated, with unit coverage for argument validation, fresh configuration, partial updates, direction checks, optional-attribute reset, full deletion, and idempotent deletion.
SRv6 decap hardware programming remains dependent on ASIC and SDK support. Unsupported builds retain the configuration but log a warning and skip SAI decap tunnel creation. The
termination-typeoption is persisted in SRv6 configuration and state, but it is not currently consumed bySaiSrv6TunnelManager.Test Plan
pre-commit run --from-ref main --to-ref HEADfboss/oss/scripts/buck_cmake_dep_checker.py --check-files --check-sorted --from-commit main.fboss2-dev:srv6Tunnelsfields in the running agent configuration.fboss_sw_agent.serviceremained active after each commit.fboss2-dev show config running agent.Replacement for #1638, which was automatically closed.