Repository navigation
[Nexthop][fboss2-dev] Add integration tests for IpInIpTunnel.dscpMode and ecnMode - #1774
Closed
abhinav-nexthop wants to merge 1 commit into
Closed
abhinav-nexthop wants to merge 1 commit into
abhinav-nexthop wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #1811, which combines this change with the other tests for the same file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
Summary
Adds
TunnelIpInIpTest.DecapDscpMode,TunnelIpInIpTest.EncapDscpMode,TunnelIpInIpTest.DecapEcnModeandTunnelIpInIpTest.EncapEcnMode, coveringIpInIpTunnel.dscpModeandIpInIpTunnel.ecnModeas written by:Unlike the tunnel masks, these modes are programmed into hardware:
SaiTunnelManager::addTunnelpasses the DSCP mode as the SAI tunnel'sEncapDscpModefor encap andDecapDscpModefor decap, and pins the otherdirection to uniform. All four tests share a fixture helper,
checkTunnelMode(direction, mode), which creates the tunnel with the mode setto pipe (the agent default is uniform) and checks:
show hw-object IPTUNNEL) has the expectedattribute set and the other direction left at its default
interface are gone
For ECN:
DecapEcnMode(COPY_FROM_OUTER), and the test checks it there.
the mode in config and switch state but never programs it. The test checks
config/state and that
DecapEcnModestays STANDARD.The cleanup runs from a scope guard, so a failed check still leaves the switch
as it was found. Tomahawk6 has no SAI tunnel support, so the tunnel suite does
not apply there.
Test Plan
Platform 1 test result
Platform 2 test result
Platform 3 test result
Platform 4 test result