Repository navigation
[Nexthop][fboss2-dev] Add integration tests for IpInIpTunnel.dstIpMask and srcIpMask - #1773
Closed
abhinav-nexthop wants to merge 1 commit into
Closed
abhinav-nexthop wants to merge 1 commit into
abhinav-nexthop wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #1811, which combines this change with the other tests for the same file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
Summary
Adds
TunnelIpInIpTest.DecapDestinationMaskandTunnelIpInIpTest.EncapDestinationMask, coveringIpInIpTunnel.dstIpMaskas written by
config tunnel ip-in-ip encap|decap <id> destination <ip> mask <len>.The CLI stores the prefix length as an IPv6 mask address
(
/64->ffff:ffff:ffff:ffff::). The agent maps it differently perdirection: for encap it goes to the tunnel's
dstIpMaskin switch state,for decap the agent swaps directions and stores it as
srcIpMask.Both tests call a shared fixture helper,
checkTunnelMask(direction, attr),which creates the tunnel with a /64 mask, checks the mask in the running
config and in the direction-specific switch-state field, checks the other
mask field stays unset in both, then deletes the tunnel and the underlay
VLAN it created.
Adds
TunnelIpInIpTest.DecapSourceMaskandTunnelIpInIpTest.EncapSourceMask, coveringIpInIpTunnel.srcIpMaskaswritten by
config tunnel ip-in-ip encap|decap <id> source <ip> mask <len>.Both use the same
checkTunnelMaskhelper. Forencap the agent stores the mask as the tunnel's
srcIpMaskin switchstate; for decap it swaps directions and stores it as
dstIpMask. Eachtest checks the mask in the running config and the direction-specific
switch-state field, checks the other mask stays unset, and removes the
tunnel and its underlay VLAN.
Test Plan
Platform 1 test result
Platform 2 test result
Platform 3 test result
Platform 4 test result