Repository navigation
docs: Add Mautic 8 change notices to Plugin database, MVC, permissions, and cache pages (7.1) - #824
promptless-for-oss wants to merge 6 commits into
Conversation
…s, and cache pages (7.1)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
…de guide anchors UPGRADE-8.0.md covers the removed and undispatched *Events constants, and mautic#772 removed the upgrade guide sections these links targeted.
|
/aside @escopecz can you please help to review this PR? I want to know if the wordings here are okay to inform folks of what they will expect in Mautic 8. If this example is acceptable, then I can confidently merge PRs that hold this kind of information. TIA! ✨ |
Open in Promptless
Description
Plugin developers who read the 7.1 docs need to know which documented APIs change or go away in Mautic 8 before they upgrade. This PR adds a
.. warning::notice next to each affected passage indocs/plugins, linked toUPGRADE-8.0.md.Changes:
database.rst: notices onClassMetadataBuilder::addContact()(removed in Mautic 8) and oncreateManyToMany()/createOneToMany()(they return Doctrine's association builders).mvc.rst: notice that Mautic deprecatedMautic\CoreBundle\Controller\FormControllerin Mautic 2.3 and removes it in Mautic 8 (useAbstractFormController).permissions.rst: notices in Using permissions (mautic.securitybecomesCorePermissions::class), Creating custom permissions (Mautic 8 deprecates the$paramsconstructor argument), and Permission aliases (getSynonym()overrides need the: arrayreturn type).cache.rst: notice in Configuration (mautic.cache.adapter.*service IDs become adapter class names).docs/links/mautic_8_upgrade.py: link file with one:xref:target,Mautic 8 UPGRADE-8.0.md, which points toUPGRADE-8.0.mdin the Mautic repository. Every Mautic 8 notice PR on the 7.x branches ships an identical copy, so whichever merges first adds it.Revision note: following the maintainer's direction that
UPGRADE-8.0.mdis the one place for Mautic 8 upgrade steps, every notice in this PR follows the approved #834 pattern and links only toUPGRADE-8.0.md. The link file is trimmed to that one entry, so the notices no longer depend on sections of the 8.0 Plugin upgrade page. The cache adapter notice is shortened to the change and the upgrade pointer.Review pass (from #821): the
FormControllernotice now names the class and uses the past tense for the 2.3 deprecation, matching the 7.0 PR. None of the other notices covers a deprecation that starts in Mautic 7.0, so none needs a 'since Mautic 7.0' line.Validation: Vale reports no new alerts on the changed lines. A local Sphinx 9.1 build of this branch reports no new warnings compared with the base branch. The PR no longer depends on any 8.0 PR, so it can merge in any order.
Review pass (@adiati98, line 64 of
database.rst): theaddContact()notice now names the removed method instead of 'this': 'Mautic removesaddContact()in Mautic 8.' The same fix is applied to the 7.0, 7.1, 7.2, and 7.3 versions of this PR (#821, #824, #827, #830).Linked issue
None
Screenshots or screen recordings
N/A
Trigger Events