Repository navigation
Add opt-in data_length to write audit logs - #170
Merged
Merged
Conversation
Log the payload size of create and setData requests (including failed requests and members of successful multis) as data_length when zookeeper.audit.dataLength.enable=true. Disabled by default; existing audit output is unchanged when off. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bellatrix007
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
data_lengthfield (payload size in bytes) to audit records forcreatevariants andsetData, including failed requests and members of successful multis. Null/empty data is0. Payloads are never logged.Gated by
zookeeper.audit.dataLength.enable(oraudit.dataLength.enablein zoo.cfg), defaultfalse, read at startup and effective only whenzookeeper.audit.enable=true. With the flag off, audit output is unchanged.This is the
data_length-only subset of #152.Tests
AuditDataLengthTest: create/setData, empty data, failed writes, multi with a check op.StandaloneServerAuditTest(flag off) unchanged and passing.🤖 Generated with GitHub Copilot CLI