Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
…ferences, README, and structure
# Conflicts: # README.md # docs-site/src/content/docs/reference/code-signing.md # docs-site/src/content/docs/tr/reference/code-signing.md # readme/README.fr.md # readme/README.ja.md # readme/README.ko.md # readme/README.ru.md # readme/README.tr.md # readme/README.zh-CN.md # readme/README.zh-TW.md # readme/i18n-manifest.json # structure/telemetry.md
…sent, including a long-running opted-out proxy
…est) into layer 05 Conflicts: the privacy statement in README, its translations and both code-signing pages keeps this layer's wording and adds the Windows installer option; the translation manifest hash and the docs-link-targets pin follow it.
…o turn telemetry off
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed layer 5 at e63fb2e2. I compared the guide, the configuration reference, the README/code-signing privacy statement and structure/telemetry.md with the code in #8300/#8303/#8304.
What matches the code: the consent precedence table, the human-only consent paths, the env opt-out semantics including the long-running opted-out proxy, the D1 day-after-consent rule, the payload field list and closed rosters, the never-sent list, local file modes and the per-day hash. The README privacy line in this layer is accurate. It names the installer checkbox and links the guide, and it replaces the earlier "turned off at install time in that prompt" wording.
Items to update together with the collector fixes I requested on #8304:
- Guide lines 300–309 (small cohorts): once #8304 changes how folding works, this description has to change with it. Even as written today, "folds rows with fewer than 10 install-days" lets a single install that reports on 10+ days be published alone. The text should not suggest that folding protects single installs until the threshold works per day.
- Guide line 310: "can be forged within the per-IP-hash rate limit" is only a bound once IPv6 is keyed by prefix (#8304, item 2).
- Guide line 116 ("in the proxy environment"): correct, but add one sentence that a background service (systemd/launchd/Task Scheduler) does not inherit variables exported in an interactive shell, and point to
ocx telemetry statusto confirm the effective state.
This is a COMMENT, because the doc text has to follow the #8304 outcome. I found no factual errors in the rest of the layer. Head CI is still queued.
Conflict in structure/telemetry.md: keep this layer's wording and fold in the lower layers' changes (pending decision, opt-out owners, unreadable state, the disk-read cached GET) and the collector's per-day distinct-install threshold and /64 rate-limit key.
…d-2 docs findings - The Windows installer item describes the machine-wide choice, in-app updates and the held decline on a fresh install. - Small-cohort protection is described as a per-day, distinct-install threshold; the rate limit as a cf-connecting-ip key with IPv6 on the /64 and real retention. - The dashboard switch records accept directly; only ocx telemetry enable prompts. - Retry-After is honored when present, otherwise about 15-20 minutes of backoff. - The code-signing page drops the repeated Privacy label and names opencodex as the subject of the version-check sentence.
…d installer re-run behaviour
|
@Ingwannu thanks. All three items are in the guide at
Verification at this head (isolated home): typecheck, privacy scan, structure check, 557 tests, 0 fail; the docs-site build passes on #8308's head. |
# Conflicts: # README.md # docs-site/src/content/docs/reference/code-signing.md # docs-site/src/content/docs/tr/reference/code-signing.md # readme/README.fr.md # readme/README.ja.md # readme/README.ko.md # readme/README.ru.md # readme/README.tr.md # readme/README.zh-CN.md # readme/README.zh-TW.md # readme/i18n-manifest.json # structure/telemetry.md
…nt and say how the installer reads unrecognized values Brings the layer 5 rewrite of the README privacy line (and its seven copies), the code-signing privacy section (en, tr) and the docs-link-targets pin in line with layers 2 and 2b; readme/i18n-manifest.json records the resynced README hash.
…ller opt-out once the app starts
# Conflicts: # README.md # docs-site/src/content/docs/reference/code-signing.md # docs-site/src/content/docs/tr/reference/code-signing.md # readme/README.fr.md # readme/README.ja.md # readme/README.ko.md # readme/README.ru.md # readme/README.tr.md # readme/README.zh-CN.md # readme/README.zh-TW.md # readme/i18n-manifest.json # structure/telemetry.md
Summary
Layer 5 of the telemetry stack (base: #8304). This is the public documentation for the telemetry added in layers 2–4, following
devlog/_plan/261107_telemetry_dashboard/040_docs_privacy.md.guides/telemetry("Telemetry and privacy", added to the Guides sidebar). It covers:ocx telemetry disable,OCX_TELEMETRY=0andDO_NOT_TRACK=1.GET /v1/stats, and that the collector is not deployed yet.reference/configuration/server.md: documents thetelemetryblock and both environment variables.guides/web-dashboard.md: gains the Proxy details telemetry row.structure/telemetry.md: gains the collector and guide paths./dashboardyet; layer 6 adds that route and link.Review round 1
code-signing.mdlinks the guide. Merging layer 4 in conflicted with layer 2's rewrite of the same statement; this layer's linked version was kept.d8fc29c2c1: the docs build passes (95,036 links), and 440 docs and structure tests pass.Review round 2
guides/telemetry.mdnow says that every day covered by an env opt-out stays unsent, including each day a proxy started withOCX_TELEMETRY=0keeps running and the day the opt-out ends (envOptOutActiveSince, feat(telemetry): default-on anonymous telemetry core with a human-only consent boundary #8300).structure/telemetry.mdkeeps this layer's wording plus the marker rule.4b382aaec3, isolated home (env -i): typecheck, privacy scan, structure check pass; alltests/ci-workflows/docs-*.test.ts, telemetry client and guard suites 484 pass, 0 fail;docs-sitebuild checked 95,036 internal links across 649 pages. Pushed with--no-verify(no pre-push hook exists; checks ran by hand).Review round 3 (head
b66bb7e1f9)cf-connecting-ipkey with IPv6 on the /64.ocx telemetry enableprompts;Retry-Afteris honoured when present, otherwise about 15–20 minutes of backoff;structure/telemetry.mdmerges the lower layers' changes.Review round 4 (head
9179c5eb31)OCX_TELEMETRYandDO_NOT_TRACKonly reach a proxy that inherits them, a background service (systemd, launchd, Task Scheduler) does not see shell exports, andocx telemetry statusasks the running proxy for the state it actually uses.optoutin any letter case; re-running a newer installer without changing the box keeps the earlier decision and does not re-apply it over a later dashboard choice.--no-verify.Round 5 (head
02524d4c7f)docs-link-targetspin) names the per-day install hash, matching layers 2 and 2b.sendkeeps telemetry on and any other installer value turns it off.--no-verify.Round 6 (head
9e26c1df05)ocx telemetry disablestops it at once.--no-verify.Round 7 (head
4be582b97c)docs-link-targetspin) lists every field sent, matching layer 2.--no-verify.Verification
cd docs-site && bun run build: 649 pages built. The internal-link checker passes (95,028 links).bun test tests/ci-workflows/ tests/cli/cli-headless-parity.test.ts: 1,936 pass, 0 fail. This includes thedocs-*claim guards anddocs-link-targets.bun run typecheck,bun run structure:checkandbun run privacy:scan: pass.Checklist