Repository navigation
🌱 Recover panics in authentication webhooks, change webhook CounterVec to Counter metrics - #3648
Merged
kubernetes-prow[bot] merged 1 commit intoNov 8, 2026
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
Member
Author
|
/hold /assign @alvaroaleman |
kubernetes-prow
Bot
added
size/L
alvaroaleman
reviewed
Nov 5, 2026
| var ( | ||
| // WebhookPanics is a prometheus counter metrics which holds the total | ||
| // number of panics from authentication webhooks. | ||
| WebhookPanics = prometheus.NewCounterVec(prometheus.CounterOpts{ |
Member
There was a problem hiding this comment.
Why is it a vec? We never set any label values, that doesn't seem correct
Member
Author
There was a problem hiding this comment.
Because I copied it from admission without thinking about it :)
Fixed
sbueringer
force-pushed
the
pr-auth-recover-panic
branch
from
November 5, 2026 12:44
50d0099 to
7445feb
Compare
sbueringer
changed the title
kubernetes-prow
Bot
added
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 62b45e9cbef757a1d92c4baec5e0307dad5e4310 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the same panic recovery we have in admission and conversion webhooks also for authentication webhooks