Skip to content

⚠ Use context.Context for API discovery - #3617

Open
sbueringer wants to merge 1 commit into
kubernetes-sigs:mainfrom
sbueringer:context-aware-api
Open

sbueringer wants to merge 1 commit into
kubernetes-sigs:mainfrom
sbueringer:context-aware-api

Conversation

@sbueringer

@sbueringer sbueringer commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

With this PR we are now using context.Context for API discovery.

This is possible since kubernetes/kubernetes#129109 added support for it in client-go.

With some help from Claude

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: sbueringer / name: Stefan Bueringer (1d5594c)

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 5, 2026
@sbueringer sbueringer changed the title [WIP] Discovery with context [WIP] ⚠ Discovery with context Oct 5, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 16, 2026
@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2026
@sbueringer
sbueringer force-pushed the context-aware-api branch 2 times, most recently from ea8daec to b61a24d Compare October 16, 2026 15:26
@sbueringer sbueringer changed the title [WIP] ⚠ Discovery with context ⚠ Use context.Context for API discovery Oct 16, 2026
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2026
@sbueringer

Copy link
Copy Markdown
Member Author

/hold
/assign @alvaroaleman

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2026
@sbueringer

Copy link
Copy Markdown
Member Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants