Repository navigation
fix: preserve input dimensions in ones and zeros - #3718
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onesandzerosnormalize BigNumber dimensions in place, replacing entries in the caller's array with numbers. Reusing that array consequently changes the generated element type on the second call, and frozen BigNumber dimensions throw even though they are otherwise valid. Copy the dimensions before normalization in both constructors, preserving their existing validation and storage behavior.The regression tests cover repeated calls, frozen arrays, dense/sparse storage and validation failures. Local build-and-test, lint, TypeScript checks, coverage and FirefoxHeadless passed; public CJS/ESM/UMD checks also passed. Node 20/24 and the remote browser matrix were not run locally.
From Tool: Hermes Agent; assisted implementation and independently checked regression behavior.