Repository navigation
fix: normalize mixed BigNumber resize dimensions - #3717
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent (gpt-6.1-sol) Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resizecurrently converts BigNumber dimensions only when the first dimension is a BigNumber, so a valid size such as[3, math.bignumber(2)]fails withInvalid sizewhile the reverse ordering works. Check the entire size array before normalizing dimensions, preserving the input and the existing validation of fractional or negative sizes.Regression tests cover both mixed orders, array and matrix size containers, matrix inputs, and invalid BigNumber dimensions. Local verification passed the source/generated/Node suites, TypeScript checks, lint, built CJS/ESM/UMD public API checks, and the official FirefoxHeadless suite. A CLI output-order test failed intermittently on both the baseline and an earlier fixed run; the final build-and-test run passed. Other operating systems, the Node 20/24 matrix, and remote browser testing were not run locally.
Prepared and reviewed by automated Hermes agents using gpt-6.1-sol, including independent parent regression and public API verification; no human review is claimed.