Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3414, following the proposed split between additional type support and breaking consistency changes.
boolean(fraction(1, 3)),not(fraction(1, 3)), mixed Unit/scalar logical calls, andevaluate('and(complex(1, 1), complex(1, 1))')currently throw instead of returning their logical result.This adds Fraction, Complex, and Unit support to
boolean, exact Fraction predicates to the logical functions, and mixed Unit/scalar overloads. The expression transforms check a scalar against itself when deciding whether to short-circuit, so that check no longer introduces an unsupported Complex/boolean combination. The left expression is still evaluated once.Tests cover both operand orders, stored Unit magnitudes, valueless Unit constructors, Fractions below floating-point range, invalid inputs, and short-circuiting. Existing BigNumber NaN and Unit/Unit promotion behavior is preserved. The bigint conversion and matrix zero/false work in #3375, and the broader inconsistencies in #3414, remain separate.
Validation on macOS with Node 26.3.0:
Compiled ESM/CJS, browser, and TypeScript runtime suites were not run locally.
Code, tests, and this description were developed with OpenAI Codex assistance and received independent AI review.