Repository navigation
Create an issue form template for Yearly Accomplishments - #8861
meghan-oconnell merged 1 commit into
Conversation
github-project-automation
Bot
moved this to PR Needs review
in P: HfLA Website: Project Board
github-actions
Bot
added
role: front end
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: T, W 4-6pm |
|
Availability: 11/2/26 7-9pm |
There was a problem hiding this comment.
Hello @MStoutTech great job!
- The issue is correctly linked.
- The PR and it's branches are structured correctly.
- I previewed your yaml file in the browser and compared it to other .github/ISSUE_Template files and yours looked great. I did not see any deficiencies when comparing to the linked issue either.
- All of the projects i prod are listed in your "Project Team" dropdown.
- All of the links in the "Project URL on hackforla.org website" dropdown work.
- The other dropdowns appear correct as well.
- The comment is correctly left on the bottom of the issue form template.
Great work! Thank you for working on this!
yepezjuan
left a comment
yepezjuan
left a comment
There was a problem hiding this comment.
Hi @MStoutTech good work!
Your PR is titled and formatted. Did not notice and discrepancies in comparing your .yml file and the issue requirements. All drop down options seem to be in place as well as complete functional link navigation!
github-project-automation
Bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
|
Merge team review: Hey @MStoutTech! Thank you for working on this. I noticed that there are more Project urls (40) than there are Project teams (35). Is this intentional? For example, what would someone working on the 'Youth Justice Nav' project put for their Project team? I was trying to find a complete list of teams (Where did you get the list you included? I'm checking in with rest of merge team too), and I could only find this: https://github.com/orgs/hackforla/teams. I wouldn't say you need all of those teams, but at least one associated to each Project url. In the meantime, I'll call this out to the rest of the merge team to verify (Availability: I'm around most of the weekend this weekend and will check back a couple of times each day). Other than that, I tested it and it looks great! |
|
@meghan-oconnell I did ask if the lists were the same as the example linked in the issue #8476 and so used the same lists. If there is a more recent list to use, I will happily update the lists :) |
|
@MStoutTech Got it! I see, thanks for pointing me that way. I figured you'd thought of this too and just wanted to confirm. It could be the case that some teams have multiple projects or something. I'll go ahead and merge this! Thank you for your work on this! |
Fixes #8476
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
No before visuals
Visuals after changes are applied