Repository navigation
fix(gfql): preserve timezone-aware temporal equality - #2234
Merged
Merged
Conversation
lmeyerov
force-pushed
the
fix/gfql-tz-aware-filter-equality
branch
3 times, most recently
from
October 24, 2026 03:02
d169d26 to
8c2ef94
Compare
lmeyerov
force-pushed
the
fix/gfql-tz-aware-filter-equality
branch
2 times, most recently
from
October 24, 2026 04:29
59d6f6e to
d1a27c4
Compare
lmeyerov
force-pushed
the
fix/gfql-tz-aware-filter-equality
branch
from
October 24, 2026 04:44
d1a27c4 to
ef1b617
Compare
Contributor
|
I tested this branch at Equality is fixed, once
Timezone-naive columns and 1. (JSON
2.
It's the same localization gap as equality, so it might be worth covering here too. The other items in #2235 (2 to 7) are unchanged on this branch, as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
python -m pytest -q graphistry/tests/compute/gfql/test_temporal_leak_family_1915.py graphistry/tests/test_compute_filter_by_dict.py -k 'not cudf' --no-header→ 95 passed, 21 deselected.ruff check graphistry/compute/filter_by_dict.py graphistry/tests/compute/gfql/test_temporal_leak_family_1915.py→ passed.python -m mypy graphistry/compute/filter_by_dict.py graphistry/tests/compute/gfql/test_temporal_leak_family_1915.py→ same 14 pre-existing errors.26.02.01, exact tracked source atfdb24db92e0db93c7f98dc650b74fb4fb0cd1432→ 116 passed, 0 skipped.40053270807, CodeQL, and RTD are green.