Skip to content

Upgrade jQuery to 4.0.0 and add Firefox data consent - #188

Merged
zhenghaoz merged 1 commit into
masterfrom
codex/upgrade-jquery-firefox-consent
Oct 4, 2026
Merged

zhenghaoz merged 1 commit into
masterfrom
codex/upgrade-jquery-firefox-consent

Conversation

@zhenghaoz

Copy link
Copy Markdown
Collaborator

The Firefox validator reports dynamic innerHTML assignments in the bundled jQuery 3.6.1 and a missing gecko.data_collection_permissions declaration. Upgrade both browser packages to the unmodified official jQuery 4.0.0 distribution, replace removed .click() shortcuts with .on('click', ...), and escape API-provided text and attribute values in recommendation templates. Both extension manifests are bumped to 0.12.

Declare required authentication information, identifying information, browsing activity, website activity, and website content to reflect session cookies, GitHub username queries, viewed repositories, starred/read feedback, and repository descriptions already transmitted by the extension. Set the minimum Firefox version to 142 so the built-in consent experience is available and the validator's inherited Android minimum-version check passes. This raises the minimum supported Firefox version.

Validation:

  • Chrome and Firefox packages build with the existing just recipes; archive checks confirm both load jQuery 4.0.0 and no longer ship 3.6.1.
  • Six local jsdom smoke scenarios pass: related-repository placement/pagination/SPA navigation; delayed React description; authenticated recommendations and next batch with HTML injection payloads; anonymous starred-repository recommendations; repository error rendering; homepage error rendering. Error scenarios also verify the static rate-limit login link.
  • JavaScript syntax checks and git diff --check pass.
  • Mozilla addons-linter 10.13.0 reports 0 errors and 2 warnings, down from 4 warnings. The missing data-permissions warning and the reported old-jQuery warning at line 2, column 10471 are gone. Two generic UNSAFE_VAR_ASSIGNMENT warnings remain inside the unmodified jQuery 4.0.0 at line 2, columns 33302 and 44621; its HTML parsing APIs still use innerHTML. No lint rules are disabled. Extension-controlled external template values are now escaped.

Vendored jQuery SHA-256: 39a546ea9ad97f8bfaf5d3e0e8f8556adb415e470e59007ada9759dce472adaa.

@zhenghaoz
zhenghaoz merged commit 1015873 into master Oct 4, 2026
1 check passed
@zhenghaoz
zhenghaoz deleted the codex/upgrade-jquery-firefox-consent branch October 4, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant