Repository navigation
Upgrade jQuery to 4.0.0 and add Firefox data consent - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Firefox validator reports dynamic
innerHTMLassignments in the bundled jQuery 3.6.1 and a missinggecko.data_collection_permissionsdeclaration. Upgrade both browser packages to the unmodified official jQuery 4.0.0 distribution, replace removed.click()shortcuts with.on('click', ...), and escape API-provided text and attribute values in recommendation templates. Both extension manifests are bumped to 0.12.Declare required authentication information, identifying information, browsing activity, website activity, and website content to reflect session cookies, GitHub username queries, viewed repositories, starred/read feedback, and repository descriptions already transmitted by the extension. Set the minimum Firefox version to 142 so the built-in consent experience is available and the validator's inherited Android minimum-version check passes. This raises the minimum supported Firefox version.
Validation:
justrecipes; archive checks confirm both load jQuery 4.0.0 and no longer ship 3.6.1.git diff --checkpass.UNSAFE_VAR_ASSIGNMENTwarnings remain inside the unmodified jQuery 4.0.0 at line 2, columns 33302 and 44621; its HTML parsing APIs still useinnerHTML. No lint rules are disabled. Extension-controlled external template values are now escaped.Vendored jQuery SHA-256:
39a546ea9ad97f8bfaf5d3e0e8f8556adb415e470e59007ada9759dce472adaa.