Repository navigation
Fix MySQL backups with generated search columns - #184
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backups produced by the MariaDB client against MySQL include explicit values for the generated
items.gorse_search_documentcolumn, causing restores to fail with ERROR 3105. Use the official MySQL 8.4 client in the backup image and export INSERTs with explicit column lists so generated columns are omitted and recomputed during restore.The backup script also uses a consistent transaction snapshot, disables column statistics and GTID output for portability, rejects MariaDB dump clients, and enables
pipefailso failed exports cannot be uploaded as successful backups.Validation:
bash -n scripts/backup.shandgit diff --check.Rebuild the backup service to apply:
docker compose up -d --build backup. Existing backups are unchanged and may still require repair.