[Test Coverage] src/docker-manager.ts by github-actions[bot] · Pull Request #9846 · github/gh-aw-firewall

github-actions · 2026-10-12T08:54:10Z

Adds unit tests to src/docker-manager.test.ts covering parseDifcProxyHost through the barrel: empty input defaults, scheme stripping, default port, (redacted) port preservation, IPv6 bracket stripping, and rejection of non-numeric or out-of-range ports.

Targeted Jest run: 25/25 passing. ESLint on the file: clean. Existing tests are unchanged.

Generated by Test Coverage Improver · copilot · auto · 22.1 AIC · ⊞ 9.5K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The tests duplicate existing coverage and incorrectly codify acceptance of a malformed empty host.

2 open findings

What changed in this PR

Adds parser tests through the docker-manager barrel.

Changes:

Tests defaults, schemes, ports, IPv6, and invalid inputs.
Duplicates existing host-config parser coverage.

File	Description
`src/docker-manager.test.ts`	Adds `parseDifcProxyHost` behavioral tests.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    });
+
+    it('rejects malformed values and out-of-range ports', () => {
+      expect(() => dockerManager.parseDifcProxyHost('http://')).not.toThrow();


    });
  });

+  describe('parseDifcProxyHost via barrel', () => {


lpcox · 2026-10-12T14:22:24Z

@copilot address review feedback

Copilot · 2026-10-12T14:26:30Z

@copilot address review feedback

Removed the duplicate parser behavior tests from the barrel suite; the dedicated host-config tests and barrel identity assertions remain. Commit: f4fa821.

github-actions · 2026-10-12T14:40:09Z

✅ Copilot review passed with no inline comments.

@github-actions[bot] Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-10-12T14:43:50Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-10-12T14:43:51Z

Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-10-12T14:43:51Z

🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request...

github-actions · 2026-10-12T14:43:52Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-10-12T14:43:52Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-10-12T14:43:52Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-10-12T14:43:52Z

🪪 Smoke Copilot BYOK AOAI (Entra) is testing Azure OpenAI BYOK (Entra / GitHub OIDC) mode on this pull request...

github-actions · 2026-10-12T14:43:52Z

🔑 Smoke Copilot BYOK AOAI (api-key) is testing Azure OpenAI BYOK (api-key) mode on this pull request...

github-actions · 2026-10-12T14:43:53Z

💎 Smoke Gemini is crystallizing results on this pull request...

github-actions · 2026-10-12T14:43:53Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-10-12T14:43:53Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-10-12T14:43:54Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-12T14:44:02Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #9846

github-actions · 2026-10-12T14:44:19Z

✅ Smoke Claude passed

Generated by Smoke Claude for #9846

github-actions · 2026-10-12T14:53:33Z

Smoke Test: Cloud Hypervisor + Copilot

PASS — list_pull_requests call succeeded (returned PR data).
PASS — https://github.com returned HTTP 200.
PASS — Wrote/read back /tmp/gh-aw/agent/smoke-cloud-hypervisor-38265004983.txt successfully.
PASS — (example.com/redacted) blocked by firewall (curl exit 60 / HTTP 000).

All checks passed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:53:43Z

Smoke Test: Copilot BYOK ✅ PASS

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

✅ GitHub MCP: Listed 2 merged PRs (chore: upgrade gh-aw workflows to v0.91.8 #9852, chore: validate merged NVX guest handoff #9835)
✅ github.com Connectivity: HTTP 200
✅ File Write/Read: smoke-test-copilot-byok.txt verified
✅ BYOK Inference Path: Active and functional

Assignee: @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:53:53Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
GitHub CLI	✅ PASS
File	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #9846 · claude · haiku45 · 24 AIC · ⊞ 6.1K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:54:03Z

Smoke services: PASS

✅ Redis PING → PONG
✅ pg_isready → accepting connections
✅ psql SELECT 1 → 1

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:54:04Z

Smoke Copilot — PR: "[Test Coverage] src/docker-manager.ts"

GitHub MCP: ✅
github.com (HTTP 200): ✅
File write/read: ✅
Overall: PASS — author @github-actions[bot], reviewer @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:54:21Z

OTEL smoke test

✅ S1 Module loads; exports startRequestSpan, setTokenAttributes, endSpan, shutdown, isEnabled, etc.
✅ S2 OTEL tests: 3 suites, 68/68 passed
✅ S3 Env forwarding: GITHUB_AW_OTEL_TRACE_ID/PARENT_SPAN_ID in env-passthrough.ts; OTEL vars in api-proxy-env-config.ts
✅ S4 onUsage hook present in token-tracker-http.js
✅ S5 Diagnostics: otel.jsonl has 1 line (file exporter fallback)

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:55:27Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	❌	not run	❌ FAIL
Bun	hono	❌	not run	❌ FAIL
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	❌	not run	❌ FAIL
Deno	std	❌	not run	❌ FAIL
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	pass	✅ PASS
Go	env	✅	pass	✅ PASS
Go	uuid	✅	pass	✅ PASS
Java	gson	❌	not run	❌ FAIL
Java	caffeine	❌	not run	❌ FAIL
Node.js	clsx	✅	pass	✅ PASS
Node.js	execa	✅	pass	✅ PASS
Node.js	p-limit	✅	pass	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 5/8 ecosystems passed — FAIL

Failures

Bun and Deno: the install commands (curl ... | bash and curl ... | sh) were denied by the runtime permission check, so neither tool was installed and no tests ran.
Java: Maven failed with LocalRepositoryNotAccessibleException (the local repository was not accessible) for both projects. I ran it with -o (offline), which may have contributed. Compile and tests did not run.

The build-test label was not added.

Generated by Build Test Suite for #9846 · copilot · auto · 15 AIC · ⊞ 11.9K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:55:41Z

Chroot Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.15	Python 3.12.15	✅ YES
Node.js	v24.21.0	v22.23.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Result: Not all tests passed (Node.js version mismatch), so the smoke-chroot label was not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-12T14:55:57Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com): HTTP 200
✅ Blocked domain (example.com): blocked
Overall: PASS — cc @lpcox

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

test: cover parseDifcProxyHost via docker-manager barrel

04b4619

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lpcox marked this pull request as ready for review October 12, 2026 14:03

Copilot AI balanced review requested due to automatic review settings October 12, 2026 14:03

Copilot started reviewing on behalf of lpcox October 12, 2026 14:04

View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

Copilot started work on behalf of lpcox October 12, 2026 14:22

View session

test: remove duplicate parser barrel coverage

f4fa821

Copilot finished work on behalf of lpcox October 12, 2026 14:26

Copilot AI requested a review from lpcox October 12, 2026 14:26

lpcox added the ready-for-aw label Oct 12, 2026

lpcox enabled auto-merge (squash) October 12, 2026 14:43

lpcox had a problem deploying to aoai-model October 12, 2026 14:43 — with GitHub Actions Failure

github-actions Bot added the smoke-cloud-hypervisor label Oct 12, 2026

github-actions Bot added the smoke-copilot-byok label Oct 12, 2026

github-actions Bot added smoke-claude smoke-services labels Oct 12, 2026

github-actions Bot added the smoke-copilot label Oct 12, 2026

lpcox deployed to aoai-model October 12, 2026 14:54 — with GitHub Actions Active

lpcox had a problem deploying to aoai-model October 12, 2026 14:54 — with GitHub Actions Failure

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Oct 12, 2026

lpcox disabled auto-merge October 12, 2026 15:30

lpcox merged commit a1fc1a5 into main Oct 12, 2026
104 of 113 checks passed

lpcox deleted the test-coverage/docker-manager-difc-a2a34936c6fef547 branch October 12, 2026 15:30

Conversation

github-actions Bot commented Oct 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

lpcox commented Oct 12, 2026

Uh oh!

Copilot AI commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

Smoke Test: Cloud Hypervisor + Copilot

Uh oh!

github-actions Bot commented Oct 12, 2026

Smoke Test: Copilot BYOK ✅ PASS

Uh oh!

github-actions Bot commented Oct 12, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented Oct 12, 2026

Chroot Version Comparison

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading