Repository navigation
Let reported general-purpose agents inherit the selected model 🤖🤖🤖 - #6330
findscripter wants to merge 3 commits into
Conversation
🔒 PR Risk Scan ResultsScanned 14 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
🚦 Submission status: 🛠️ Requires submitter fixesRisk tier: Why this tier
Automated checks
Action needed
Review
Commands
Updated for |
🔍 Vally Lint Results
Summary
Full linter output |
There was a problem hiding this comment.
🟡 Changes recommended
The shipped-agent changes leave their distributing plugin versions and marketplace entries unchanged, so update-detecting clients may not receive the model-inheritance fixes.
1 open issue
What changed in this PR
This pull request updates six general-purpose agents to inherit the user's selected/default model instead of pinning potentially unavailable model presets. It also updates agent-authoring guidance and the Custom Agent Foundry example to prefer model inheritance.
Changes:
- Removes explicit model frontmatter from six general-purpose agents.
- Updates contribution, repository, and agent-generation guidance.
- Documents model-specific exceptions and supported alternatives.
- Requires corresponding plugin version/marketplace updates and alignment with the learning-hub guidance.
This pull request requires changes.
| File | Description |
|---|---|
CONTRIBUTING.md |
Updates the example agent format and model-selection guidance. |
agents/se-technical-writer.agent.md |
Removes the pinned GPT-5 model. |
agents/se-security-reviewer.agent.md |
Removes the pinned GPT-5 model. |
agents/meta-agentic-project-scaffold.agent.md |
Removes the pinned GPT-4.1 model. |
agents/custom-agent-foundry.agent.md |
Removes the pinned model and updates the generated-agent example and guidance. |
agents/context-architect.agent.md |
Removes the pinned GPT-5 model. |
agents/agent-governance-reviewer.agent.md |
Removes the pinned GPT-4o model. |
AGENTS.md |
Updates agent authoring and review checklist guidance. |
.github/copilot-instructions.md |
Aligns agent guidance with model inheritance by default. |
Review effort: Lite (auto)
| --- | ||
| description: 'An agent that helps plan and execute multi-file changes by identifying relevant context and dependencies' | ||
| model: 'GPT-5' | ||
| tools: ['search/codebase', 'search/usages', 'read/problems', 'read/readFile', 'edit/editFiles', 'execute/runInTerminal', 'execute/getTerminalOutput', 'web/fetch'] |
| name: Display name for the agent (optional, defaults to filename) | ||
| argument-hint: Guidance text for users on how to interact (optional) | ||
| tools: ['tool1', 'tool2', 'toolset/*'] # Available tools | ||
| model: Claude Sonnet 4 # Optional: specific model selection |
There was a problem hiding this comment.
This is probably incorrect guidance as it's for a Foundry agent, not a Copilot agent.
| Omit `model` so the agent inherits the selected/default model. Add a preset only for a documented model-specific requirement, with supported alternatives. | ||
|
|
There was a problem hiding this comment.
This is probably incorrect guidance as it's for a Foundry agent, not a Copilot agent.
| Omit `model` by default so the agent inherits the user's selected/default model, as described in the [custom agent configuration reference](https://docs.github.com/en/copilot/reference/custom-agents-configuration). Set it only when the workflow has a documented model-specific requirement, and include supported alternatives. | ||
|
|
There was a problem hiding this comment.
No need to have this if we remove the point about the model property.
aaronpowell
left a comment
There was a problem hiding this comment.
I've provided some inline comments of changes that are likely required.
🧩 Canvas smoke test✅ Passed · 0 error(s), 1 warning(s)
Plugin
|
| Field | Value |
|---|---|
| Description | A date-aware demotivational calendar canvas with an original daily letdown for every month and day. |
| Author | — |
| License | MIT |
| Keywords | calendar, daily, demotivation, humor, offline |
| Extensions | demotivational-calendar |
| Materialize | ✅ |
| Install | ✅ |
Changed plugin files
plugins/demotivational-calendar/README.mdplugins/demotivational-calendar/plugin.json
Extension demotivational-calendar
| Field | Value |
|---|---|
| Registered by | demotivational-calendar |
| Package | — |
| Preview | 400×923, 87.4 KB |
| Modules | 3 (2 reachable from extension.mjs) |
| Files | 6 |
Permissions and capabilities (static analysis of modules reachable from extension.mjs)
- File system access (node:fs)
- Network sockets / local server (node:http, node:net, ...)
Warnings
- calendar.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
Changed extension files
extensions/demotivational-calendar/README.mdextensions/demotivational-calendar/assets/preview.pngextensions/demotivational-calendar/calendar.test.mjsextensions/demotivational-calendar/extension.mjsextensions/demotivational-calendar/index.htmlextensions/demotivational-calendar/server.mjs
Static checks compile modules without executing them. Minimum preview size is configurable with CANVAS_PREVIEW_MIN_WIDTH/CANVAS_PREVIEW_MIN_HEIGHT. Workflow run


Description
Refs #5747.
The six general-purpose profiles named in the issue select models that may be unavailable in a user's client or account. Remove those presets so each profile uses the client's selected/default model. The contribution example leaves
modelunspecified, and the review guidance allows documented model-specific requirements with supported alternatives.The six profiles retain their names, descriptions, tools, other frontmatter values, and complete bodies. The Foundry generation template retains its existing optional
modelexample. The Learning Hub explains default inheritance and client-specific model and reasoning overrides.Publish the shipped-agent changes by bumping
context-engineeringandsoftware-engineering-teamto1.0.1, andawesome-copilotto1.1.1, then regenerating their marketplace versions.Validation
modelwas removed.npm run buildandgit diff --checkpassed.npm run plugin:validatepassed. Enumerating all distributing manifests identifies exactly those three plugins; their versions match the generated marketplace.This PR covers the six reported profiles and authoring guidance. No live invocation or backend-model telemetry was collected across the different clients.
AI-assisted implementation and validation.