Skip to content

Let reported general-purpose agents inherit the selected model 🤖🤖🤖 - #6330

Open
findscripter wants to merge 3 commits into
github:mainfrom
findscripter:findscripter/fix-agent-model-defaults
Open

findscripter wants to merge 3 commits into
github:mainfrom
findscripter:findscripter/fix-agent-model-defaults

Conversation

@findscripter

@findscripter findscripter commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Refs #5747.

The six general-purpose profiles named in the issue select models that may be unavailable in a user's client or account. Remove those presets so each profile uses the client's selected/default model. The contribution example leaves model unspecified, and the review guidance allows documented model-specific requirements with supported alternatives.

The six profiles retain their names, descriptions, tools, other frontmatter values, and complete bodies. The Foundry generation template retains its existing optional model example. The Learning Hub explains default inheritance and client-specific model and reasoning overrides.

Publish the shipped-agent changes by bumping context-engineering and software-engineering-team to 1.0.1, and awesome-copilot to 1.1.1, then regenerating their marketplace versions.

Validation

  • Parsed all six YAML frontmatters and compared them with the base revision: only model was removed.
  • All six agent bodies match the original revision exactly, including the Foundry generation template. The contribution example only removes its preset model line.
  • npm run build and git diff --check passed.
  • Current-head Linux preview CI passed the website data regressions and full Astro build.
  • npm run plugin:validate passed. Enumerating all distributing manifests identifies exactly those three plugins; their versions match the generated marketplace.
  • Inheritance behavior was checked against the GitHub configuration reference and VS Code reference.

This PR covers the six reported profiles and authoring guidance. No live invocation or backend-model telemetry was collected across the different clients.

AI-assisted implementation and validation.

@findscripter
findscripter requested review from a team as code owners November 9, 2026 13:06
Copilot AI auto review requested due to automatic review settings November 9, 2026 13:06
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 14 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added agent PR touches agents needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk awaiting-automation merge-risk:high labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 🛠️ Requires submitter fixes

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • .github/copilot-instructions.md is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Plugin and extension validation ✅ Passed Passed · logs
Plugin structure ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs
Canvas/plugin smoke test ✅ Passed Passed · logs

Action needed

  • Address the changes requested by aaronpowell, then push an update.

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission; resolution of changes requested by aaronpowell
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 70ef291 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

⚠️ Warnings or advisories found

Scope Checked
Skills 0
Agents 6
Total 6
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 1

Summary

Level Finding
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
Full linter output
### Agent files detected (not linted by vally)
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
agents/agent-governance-reviewer.agent.md
agents/context-architect.agent.md
agents/custom-agent-foundry.agent.md
agents/meta-agentic-project-scaffold.agent.md
agents/se-security-reviewer.agent.md
agents/se-technical-writer.agent.md

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The shipped-agent changes leave their distributing plugin versions and marketplace entries unchanged, so update-detecting clients may not receive the model-inheritance fixes.

1 open issue
What changed in this PR

This pull request updates six general-purpose agents to inherit the user's selected/default model instead of pinning potentially unavailable model presets. It also updates agent-authoring guidance and the Custom Agent Foundry example to prefer model inheritance.

Changes:

  • Removes explicit model frontmatter from six general-purpose agents.
  • Updates contribution, repository, and agent-generation guidance.
  • Documents model-specific exceptions and supported alternatives.
  • Requires corresponding plugin version/marketplace updates and alignment with the learning-hub guidance.

This pull request requires changes.

File Description
CONTRIBUTING.md Updates the example agent format and model-selection guidance.
agents/​se-technical-writer.agent.md Removes the pinned GPT-5 model.
agents/​se-security-reviewer.agent.md Removes the pinned GPT-5 model.
agents/​meta-agentic-project-scaffold.agent.md Removes the pinned GPT-4.1 model.
agents/​custom-agent-foundry.agent.md Removes the pinned model and updates the generated-agent example and guidance.
agents/​context-architect.agent.md Removes the pinned GPT-5 model.
agents/​agent-governance-reviewer.agent.md Removes the pinned GPT-4o model.
AGENTS.md Updates agent authoring and review checklist guidance.
.github/​copilot-instructions.md Aligns agent guidance with model inheritance by default.

Review effort: Lite (auto)

---
description: 'An agent that helps plan and execute multi-file changes by identifying relevant context and dependencies'
model: 'GPT-5'
tools: ['search/codebase', 'search/usages', 'read/problems', 'read/readFile', 'edit/editFiles', 'execute/runInTerminal', 'execute/getTerminalOutput', 'web/fetch']
@findscripter
findscripter requested a review from a team as a code owner November 9, 2026 13:20
Copilot AI auto review requested due to automatic review settings November 9, 2026 13:20
@github-actions github-actions Bot added plugin PR touches plugins website-update PR touches website content or code labels Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer confirmation is required because changes to AGENTS.md and .github/copilot-instructions.md alter model-selection policies governing contributor authoring and automated reviews.

1 open issue

Review effort: Balanced (auto)

name: Display name for the agent (optional, defaults to filename)
argument-hint: Guidance text for users on how to interact (optional)
tools: ['tool1', 'tool2', 'toolset/*'] # Available tools
model: Claude Sonnet 4 # Optional: specific model selection

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably incorrect guidance as it's for a Foundry agent, not a Copilot agent.

Comment thread agents/custom-agent-foundry.agent.md Outdated
Comment on lines +64 to +65
Omit `model` so the agent inherits the selected/default model. Add a preset only for a documented model-specific requirement, with supported alternatives.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably incorrect guidance as it's for a Foundry agent, not a Copilot agent.

Comment thread CONTRIBUTING.md Outdated
Comment on lines +104 to +105
Omit `model` by default so the agent inherits the user's selected/default model, as described in the [custom agent configuration reference](https://docs.github.com/en/copilot/reference/custom-agents-configuration). Set it only when the workflow has a documented model-specific requirement, and include supported alternatives.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have this if we remove the point about the model property.

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided some inline comments of changes that are likely required.

Copilot AI auto review requested due to automatic review settings November 11, 2026 04:06
@github-actions

Copy link
Copy Markdown
Contributor

🧩 Canvas smoke test

✅ Passed · 0 error(s), 1 warning(s)

Check Result
Syntax, imports, file safety ✅
Preview image (≥ 400×160 PNG) ✅
Plugin manifests ✅
Materialize ✅
Install (Copilot CLI) ✅

Plugin demotivational-calendar v1.0.0

Field Value
Description A date-aware demotivational calendar canvas with an original daily letdown for every month and day.
Author —
License MIT
Keywords calendar, daily, demotivation, humor, offline
Extensions demotivational-calendar
Materialize ✅
Install ✅
Changed plugin files
  • plugins/demotivational-calendar/README.md
  • plugins/demotivational-calendar/plugin.json

Extension demotivational-calendar

demotivational-calendar preview

Field Value
Registered by demotivational-calendar
Package —
Preview 400×923, 87.4 KB
Modules 3 (2 reachable from extension.mjs)
Files 6

Permissions and capabilities (static analysis of modules reachable from extension.mjs)

  • File system access (node:fs)
  • Network sockets / local server (node:http, node:net, ...)

Warnings

  • calendar.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
Changed extension files
  • extensions/demotivational-calendar/README.md
  • extensions/demotivational-calendar/assets/preview.png
  • extensions/demotivational-calendar/calendar.test.mjs
  • extensions/demotivational-calendar/extension.mjs
  • extensions/demotivational-calendar/index.html
  • extensions/demotivational-calendar/server.mjs

Static checks compile modules without executing them. Minimum preview size is configurable with CANVAS_PREVIEW_MIN_WIDTH/CANVAS_PREVIEW_MIN_HEIGHT. Workflow run

@github-actions github-actions Bot added requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Changes to model-selection policy in AGENTS.md and .github/copilot-instructions.md alter automated review criteria and require maintainer confirmation.

1 open issue

Review effort: Balanced (auto)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent PR touches agents merge-risk:high needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk plugin PR touches plugins requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review website-update PR touches website content or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants