Skip to content

Add Copilot code review quality guidance - #3665

Merged
aaronpowell merged 3 commits into
mainfrom
aaronpowell-ai-pr-review-research
Sep 23, 2026
Merged

aaronpowell merged 3 commits into
mainfrom
aaronpowell-ai-pr-review-research

Conversation

@aaronpowell

@aaronpowell aaronpowell commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

This builds on the AI PR review research by giving Copilot Code Review repo-specific guidance for the judgment calls that deterministic checks cannot cover: repo fit, meaningful uplift, AI provenance, marketing-heavy submissions, validation evidence, trusted-source exceptions, and stale automation churn.

The change adds an active .github/skills/code-review skill, points .github/copilot-instructions.md at it for editorial review criteria, and adds CODEOWNERS protection for review-policy files because Copilot Code Review reads skills and instructions from the PR head branch. It also adds an advisory pr-quality-signal Agentic Workflow and updates the Learning Hub updater so automated docs updates reuse the current bot PR rather than creating duplicate stale PRs.

The branch is rebased onto current main and Agentic Workflows were upgraded with gh aw upgrade to v0.88.8. This refreshes the workflow runtime, generated locks, actions/container pins, maintenance workflow, and updater permissions.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

Validated all nine Agentic Workflow sources with gh aw compile --validate after the upgrade. git diff --check passed.

npm start was not run successfully in this workspace because dependency installation is currently blocked by a js-yaml package fetch 404 from the configured registry.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Copilot AI balanced review requested due to automatic review settings September 23, 2026 00:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Multiple moderate workflow scope, duplication, capability, path-gating, and target-branch issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Adds repository-specific Copilot review guidance, PR-quality automation, and Learning Hub PR deduplication guidance.

Changes:

  • Adds review-policy guidance and ownership.
  • Introduces an advisory PR-quality workflow.
  • Updates Learning Hub automation to reuse bot PRs.
File Review
CODEOWNERS Adds ownership for review-policy files. No unresolved issue identified.
.github/​workflows/​pr-quality-signal.md Moderate: excludes community/fork PRs; duplicates the existing duplicate checker; lacks changed-path gating. Nit: required workflow name is missing.
.github/​workflows/​pr-quality-signal.lock.yml Moderate: generated actor and repository guards exclude community/fork PRs.
.github/​workflows/​learning-hub-updater.md Moderate: requested PR reuse/closure operations lack required safe outputs; the PR must also target main rather than staged.
.github/​workflows/​learning-hub-updater.lock.yml Regenerated updater workflow; source capability concerns remain unresolved.
.github/​skills/​code-review/​SKILL.md Defines repository-specific review criteria. No unresolved issue identified.
.github/​copilot-instructions.md Activates the review skill. No unresolved issue identified.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/pr-quality-signal.md Resolved
aaronpowell and others added 3 commits September 23, 2026 11:36
Add a repository-specific Copilot Code Review skill for repo-fit, provenance, differentiation, validation, and marketing-signal review. Wire it into the repo review instructions and CODEOWNERS, add an advisory PR quality-signal workflow, and tighten the Learning Hub updater instructions to reuse existing bot PRs instead of creating duplicate stale update PRs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add constrained safe outputs for reusing and closing Learning Hub bot pull requests, and declare the quality-signal workflow name in source frontmatter.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Rebase the PR onto main and upgrade gh-aw to v0.88.8. Refresh setup actions, generated workflow locks, container pins, and updater permissions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aaronpowell
aaronpowell force-pushed the aaronpowell-ai-pr-review-research branch from 7f0f455 to cbdc187 Compare September 23, 2026 01:38
@aaronpowell
aaronpowell changed the base branch from staged to main September 23, 2026 01:39
@github-actions github-actions Bot added agent PR touches agents canvas-extension PR touches canvas extensions external-plugin Public external plugin submission hooks PR touches hooks instructions PR touches instructions new-submission PR adds at least one new contribution plugin PR touches plugins skills PR touches skills website-update PR touches website content or code workflow PR touches workflow automation and removed skills PR touches skills agent PR touches agents plugin PR touches plugins instructions PR touches instructions external-plugin Public external plugin submission website-update PR touches website content or code hooks PR touches hooks canvas-extension PR touches canvas extensions labels Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk label Sep 23, 2026
@aaronpowell
aaronpowell merged commit d7e4ad9 into main Sep 23, 2026
28 of 33 checks passed
@aaronpowell
aaronpowell deleted the aaronpowell-ai-pr-review-research branch September 23, 2026 03:26
itsdarklikehell pushed a commit to itsdarklikehell-interactive/awesome-copilot that referenced this pull request Sep 24, 2026
* Add Copilot code review quality guidance

Add a repository-specific Copilot Code Review skill for repo-fit, provenance, differentiation, validation, and marketing-signal review. Wire it into the repo review instructions and CODEOWNERS, add an advisory PR quality-signal workflow, and tighten the Learning Hub updater instructions to reuse existing bot PRs instead of creating duplicate stale update PRs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Fix PR review workflow feedback

Add constrained safe outputs for reusing and closing Learning Hub bot pull requests, and declare the quality-signal workflow name in source frontmatter.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Upgrade agentic workflows

Rebase the PR onto main and upgrade gh-aw to v0.88.8. Refresh setup actions, generated workflow locks, container pins, and updater permissions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk new-submission PR adds at least one new contribution workflow PR touches workflow automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants