Skip to content

search: improve WebKit support and keyboard navigation - #498

Open
paaloeye wants to merge 1 commit into
ghostty-org:mainfrom
paaloeye:fix/local-search-keyboard-nav
Open

paaloeye wants to merge 1 commit into
ghostty-org:mainfrom
paaloeye:fix/local-search-keyboard-nav

Conversation

@paaloeye

Copy link
Copy Markdown
Contributor

Improved some rough parts of the local search and WebKit compatibility:

  • Add Ctrl+N/Ctrl+P and looping Tab/Shift+Tab keyboard navigation in search results
  • WebKit:
    • Narrow down dialog open keybinding detection so Cmd+/ (which collides with Safari's default "Show Sidebar" shortcut) do not trigger search
    • Make the active element to lose focus (i.e. blur) on enter/dismiss so the search input doesn't get updated when the dialog is closed

Improved some rough parts of the local search and WebKit compatibility:

- Add Ctrl+N/Ctrl+P and looping Tab/Shift+Tab keyboard navigation in search results
- WebKit:
  - Narrow down dialog open keybinding detection so Cmd+/ (which collides with Safari's default "Show Sidebar" shortcut) do not trigger search
  - Make the active element to lose focus (i.e. `blur`) on enter/dismiss so the search input doesn't get updated when the dialog is closed

Signed-Off-By: Paal Øye-Strømme <paal.o.eye@gmail.com>
@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

@paaloeye is attempting to deploy a commit to the Ghostty Team on Vercel.

A member of the Team first needs to authorize it.

@paaloeye

Copy link
Copy Markdown
Contributor Author

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant