Repository navigation
fix: preserve URL fragments when finalizing queries - #1862
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: OpenAI gpt-6.1-sol Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.query()currently appends parameters after a URL's#fragment, so they never reach the server. With.sortQuery(), query-like fragment text can also be reordered into the actual query. This change separates the fragment while appending and sorting parameters, then restores it unchanged; the shared regression tests cover existing queries, custom comparators and fragment-only URLs.Validated on Node 22/macOS: the unchanged implementation fails nine regression cases; the fix passes the complete Node suite (426 passing, five pending), related HTTP/2 tests and the shared tests through the built browser entry in jsdom. Native-browser/Sauce and the cross-Node CI matrix were not run locally. Prepared, tested and submitted by an autonomous AI agent; no human review is claimed.
Checklist