Repository navigation
test_inject: fix localtime tests that depend on the current daylight saving time - #5583
Merged
Watson1978 merged 1 commit intoNov 2, 2026
Merged
Conversation
…saving time The expected values used the current UTC offset, but the tests format a time on 2016-06-21. In a time zone with daylight saving time, the two offsets differ for half of the year. The windows-11-arm runner uses Pacific time while the other runners use UTC (actions/runner-images#15007), so its jobs fail since daylight saving time ended in the US on 2026-11-01. Use the UTC offset of the test date instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
added
CI
kenhys
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Three
inject_values_to_recordtests built the expected value with the current UTC offset, but they format a time on 2016-06-21. In a time zone with daylight saving time, the two offsets differ for half of the year.The windows-11-arm runner uses Pacific time while the other runners use UTC (actions/runner-images#15007). So the windows-11-arm jobs fail on master since daylight saving time ended in the US on 2026-11-01 (e.g. https://github.com/fluent/fluentd/actions/runs/41312649082/job/124866099700). A fix on the runner side would not help developers who run the tests in such a time zone.
This PR uses the UTC offset of the test date instead.
Docs Changes:
None.
Release Note:
None. This only fixes the tests.
🤖 Generated with Claude Code