Repository navigation
devcontainer: skip tests on GHA - #1009
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The rename leaves a test calling an undefined symbol, preventing compilation, and the new Bincache gate incorrectly skips tests with valid devcontainer file or URL overrides.
2 open issues
What changed in this PR
This PR extends Kola’s Bincache availability filter to skip developer-container tests affected by the GitHub Actions connectivity issue tracked in flatcar/Flatcar#2032, while intending to retain Jenkins nightly coverage.
Changes:
- Renames
RequiresSysextand its filtering helper to reflect the broader Bincache requirement. - Adds the requirement to both developer-container tests and
sysext.custom-oem. - Updates Podman and ZFS registrations to use the renamed field.
| File | Description |
|---|---|
| kola/tests/sysext/zfs.go | Uses the renamed Bincache requirement for ZFS tests. |
| kola/tests/sysext/sysext.go | Adds Bincache gating to sysext.custom-oem. |
| kola/tests/podman/podman.go | Uses the renamed requirement for Podman tests. |
| kola/tests/devcontainer/devcontainer.go | Adds Bincache gating to both developer-container tests. |
| kola/register/register.go | Renames and documents the test requirement field. |
| kola/harness.go | Renames the availability helper, cached filter state, and log messages. |
Review effort: Balanced
| // SkipUnavailableBincache excludes Flatcar release builds and development builds | ||
| // that have not been uploaded to bincache. Other distributions are unaffected. | ||
| func SkipUnavailableSysext(imageVersion, arch string) bool { | ||
| func SkipUnavailableBincache(imageVersion, arch string) bool { |
Comment on lines
+419
to
+421
| if t.RequiresBincache { | ||
| if !bincacheChecked { | ||
| skipBincache = SkipUnavailableBincache(imageVersion, architecture(pltfrm)) |
That's just naming but Bincache is more generic - and the actual dependency is not on the sysext production but on the sysext availability... on Bincache. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
this is known to not work on GHA Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/skip-tests-gha
branch
from
November 12, 2026 11:00
3d53288 to
e5bbdaa
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new Bincache-based gate skips devcontainer and custom-OEM tests even when supported artifact overrides provide the required inputs, regressing local testing beyond the intended GitHub Actions workaround.
3 open issues
Review effort: Balanced
| "Http": util.Serve, | ||
| }, | ||
| // The devcontainer is available only on Bincache (so this does not work on GHA) | ||
| RequiresBincache: true, |
tormath1
marked this pull request as ready for review
November 12, 2026 11:12
chewi
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The investigation with CNCF gave nothing here: flatcar/Flatcar#2032 - so let's skip thoses tests for now, they will still be tested anyways in Jenkins nightlies.
This can help to see actual issues on external contributions from GHA.