Repository navigation
Upload .uf2 firmware to GitHub releases - #190
Merged
Merged
Conversation
The copy step only picked up *.bin and *.elf, so RP2040/RP2350 .uf2 images reached R2 but never the GitHub release. Include *.uf2 with md5/sha256 sidecars, and add an RP2040 CI build that verifies the .uf2 lands on the draft release.
build-action names the image <name>-<platform>.uf2 (ci-rp2040-rp2040.uf2), so the hardcoded ci-rp2040.uf2 never matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Copy files to output" step in
upload-to-gh-release.ymlonly copied*.{bin,elf}, so RP2040/RP2350.uf2images (e.g. esphome/firmware's pico-w and pico-2-w ESPHome Web builds) were uploaded to R2 byupload-to-r2.ymlbut never attached to the GitHub release. The glob is now*.{bin,elf,uf2}, so.uf2files are copied with.md5/.sha256sidecars like the other binaries.The other workflows don't filter by extension:
build.ymlmoves whole directories,promote-r2.ymlandpublish-firmware-to-r2.ymlfollow manifest paths (build-action puts<name>.uf2in the RP2040 manifest), andupload-to-r2.ymlsyncs the whole directory.CI now builds an RP2040 config (
tests/ci-rp2040.yaml,rpipicow) in a newbuild-rp2040job.verify-artifactschecks the.uf2is in the artifact, andverify-gh-releaseincludesuf2in its expected-asset glob and also assertsci-rp2040.uf2plus its sidecars by name, since the expected list otherwise shares the upload step's glob.nRF52 extras (
dfu-<name>.zip,<name>.hex) and extensionless host builds are still not copied to the release; left for a follow-up if wanted.