Repository navigation
Fix SimpleConnectionPool Waiters#addFirst linking the new node to head.prev instead of head.next - #6465
Merged
Conversation
…d.prev instead of head.next Fix eclipse-vertx#6463 Motivation: Waiters#addFirst sets node.next to head.prev, i.e. the last waiter instead of the first one. When at least two waiters are queued, the forward chain skips the previous first waiter: it can no longer be polled although size still counts it. The waiter is never served (until it times out) and a later poll can return null while size() > 0, leading to a NullPointerException in SetConcurrency. addFirst is used by ConnectSuccess when a connection is established with a concurrency of 0 (e.g. an HTTP/2 server advertising MAX_CONCURRENT_STREAMS=0). Changes: Link the new node to head.next. Add a pool test with a zero concurrency connection and several queued waiters. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6463 (PR #6464) to
4.xMotivation:
Waiters#addFirst sets node.next to head.prev, i.e. the last waiter instead of the first one. When at least two waiters are queued, the forward chain skips the previous first waiter: it can no longer be polled although size still counts it. The waiter is never served (until it times out) and a later poll can return null while size() > 0, leading to a NullPointerException in SetConcurrency.
addFirst is used by ConnectSuccess when a connection is established with a concurrency of 0 (e.g. an HTTP/2 server advertising MAX_CONCURRENT_STREAMS=0).
Changes:
Link the new node to head.next. Add a pool test with a zero concurrency connection and several queued waiters.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com