Repository navigation
Fold h2c upgrade header names with Locale.ROOT - #6460
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
Http1xUpgradeToH2CHandler lower-cased the HTTP/1.1 header names with String.toLowerCase(), which follows the JVM default locale, when building the HTTP/2 headers for an h2c upgrade. Under a Turkish default locale "If-None-Match" became "ıf-none-match" (dotless ı), Netty rejected the synthetic HTTP/2 request with "invalid header name" after 101 Switching Protocols had been written, and the client hung. Use Locale.ROOT and add a regression test that performs an h2c upgrade with If-None-Match and X-Request-ID headers under a tr-TR default locale. Assisted-by: Anthropic Claude (Fable 5.1) Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6459.
Http1xUpgradeToH2CHandlerlower-cased the HTTP/1.1 header names with the JVM default locale when building the HTTP/2 headers for an h2c upgrade, so under a Turkish default localeIf-None-Matchbecameıf-none-matchand Netty rejected the synthetic HTTP/2 request after101 Switching Protocols(connection error, client hang). UseLocale.ROOT, and add a regression test that upgrades withIf-None-MatchandX-Request-IDunder atr-TRdefault locale (restored infinally). The same one-token change applies to4.x.