Repository navigation
Open a block by its height - #323
Merged
Merged
Conversation
The block page takes a height as well as a hash, and /block/<height> leads to it. A block that isn't there says so, rather than failing on a null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
/blocks/block/?id=27730opens the block at that height, and a hash still works./block/27730redirects there, throughstatic/_redirects. This works on Cloudflare, so it starts working on mainnet with the move.Checks:
npm run checkspasses, and each new test fails without its change. Tried on Cloudflare's local runtime against the mainnet node:/block/27730lands on the block whose hash is in the issue, and a height past the tip gives the new message.