Skip to content

Correct stale comments and drop dead re-exports found in the nightly survey - #1505

Merged
nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-nightly
Nov 2, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
fix/stale-comments-nightly

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

This fixes comments and docs that no longer match the code, plus two dead imports and exports. Nothing changes at runtime.

  • relay/src/app.ts sent readers to index.ts for the env mapping, the WebSocket inject, and the two sweep timers. index.ts is now a three-line entrypoint. config.ts maps env, and start.ts serves, injects, and runs the sweeps; line 209 of the same file already said start.ts.
  • remote-lib-common/src/security/webcrypto.ts: randomBase64Url called itself "the one way every unguessable handle in this system is minted". The selfhost Relay mints its session tokens, presence nonces, setup tokens, and Burrow credentials with toBase64Url(randomBytes(...)), which is also a CSPRNG. The comment now states what the helper does without the "only way" claim.
  • AlertRingIndicator.tsx cited docs/specs/layout.md -> Alarm overlay for the color-mix() browser-support constraint. Neither the spec nor its rationale says that. Per AGENTS.md, a comment that states its own fact does not cite a spec, so the citation is gone.
  • scripts/deploy-lint.mjs pointed at != diagnostics in install-macos.sh by line numbers (:675, :1195) that have drifted. There are now three such sites. The comment now describes them rather than pinning lines.
  • scripts/spec-md.mjs: the header listed three consumers. It now also names security-audit-report.mjs and security-audit-codex.mjs, which import it too.
  • .claude/skills/debug-standalone-agent-browser/SKILL.md told agents to watch for [browser log] [measure] lines. Nothing in the repo has ever printed them; git log -S finds them only in the skill. It also showed eventLoopDelayMs as a number, but browser-viewer.ts logs {p99, max}.
  • Dead code: the parseAgentBrowserTabs re-export from agent-browser-connection.ts has no importer, since its users import from lib/agent-browser-tab. TerminalPaneHeader.test.tsx imported two mouse-selection functions it never used.

The lib typecheck, the TerminalPaneHeader tests, deploy-lint, and spec-lint pass. No regression test, since the changes are comments, docs, and unused bindings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5446ecb
Status: ✅  Deploy successful!
Preview URL: https://ec224970.mouseterm.pages.dev
Branch Preview URL: https://fix-stale-comments-nightly.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 1f69215 into main Nov 2, 2026
23 of 24 checks passed
@nedtwigg
nedtwigg deleted the fix/stale-comments-nightly branch November 2, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants