Repository navigation
Correct stale comments and drop dead re-exports found in the nightly survey - #1505
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
5446ecb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec224970.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-stale-comments-nightly.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes comments and docs that no longer match the code, plus two dead imports and exports. Nothing changes at runtime.
relay/src/app.tssent readers toindex.tsfor the env mapping, the WebSocket inject, and the two sweep timers.index.tsis now a three-line entrypoint.config.tsmaps env, andstart.tsserves, injects, and runs the sweeps; line 209 of the same file already saidstart.ts.remote-lib-common/src/security/webcrypto.ts:randomBase64Urlcalled itself "the one way every unguessable handle in this system is minted". The selfhost Relay mints its session tokens, presence nonces, setup tokens, and Burrow credentials withtoBase64Url(randomBytes(...)), which is also a CSPRNG. The comment now states what the helper does without the "only way" claim.AlertRingIndicator.tsxciteddocs/specs/layout.md-> Alarm overlay for thecolor-mix()browser-support constraint. Neither the spec nor its rationale says that. Per AGENTS.md, a comment that states its own fact does not cite a spec, so the citation is gone.scripts/deploy-lint.mjspointed at!=diagnostics ininstall-macos.shby line numbers (:675, :1195) that have drifted. There are now three such sites. The comment now describes them rather than pinning lines.scripts/spec-md.mjs: the header listed three consumers. It now also namessecurity-audit-report.mjsandsecurity-audit-codex.mjs, which import it too..claude/skills/debug-standalone-agent-browser/SKILL.mdtold agents to watch for[browser log] [measure]lines. Nothing in the repo has ever printed them;git log -Sfinds them only in the skill. It also showedeventLoopDelayMsas a number, butbrowser-viewer.tslogs{p99, max}.parseAgentBrowserTabsre-export fromagent-browser-connection.tshas no importer, since its users import fromlib/agent-browser-tab.TerminalPaneHeader.test.tsximported twomouse-selectionfunctions it never used.The lib typecheck, the
TerminalPaneHeadertests,deploy-lint, andspec-lintpass. No regression test, since the changes are comments, docs, and unused bindings.