Repository navigation
Allowlist public Helm chart repositories for helm update jobs - #301
Merged
v-robaiken merged 2 commits intoOct 12, 2026
Merged
Conversation
Helm update jobs for several widely used charts can no longer read their chart index since egress enforcement was enabled, so dependabot-core logs "No update possible" and closes any open update PR. Each host is the repository URL documented by its project, served from that project's own GitHub Pages site or custom domain, so they belong with the existing public chart repos as exact entries. external-secrets.io is included because charts.external-secrets.io redirects index.yaml requests there.
v-robaiken
previously approved these changes
Oct 12, 2026
# Conflicts: # internal/handlers/egress_allowlist_defaults.yaml # internal/handlers/egress_allowlist_test.go
v-robaiken
approved these changes
Oct 12, 2026
v-abhishekbhaskar
approved these changes
Oct 12, 2026
honeyankit
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Since
proxy-egress-enforcewas enabled, helm update jobs can't read the chart index for several widely used public charts. Each one fails at the firstindex.yamlrequest:The failure is silent: dependabot-core logs
Latest version is(empty) andNo update possible for keda 2.20.2, the job succeeds, and Dependabot closes the open update PRs as "no longer updatable". We lost open keda, velero, sealed-secrets, external-secrets and argo-rollouts PRs this way.This PR adds the hosts to
ecosystem_default_domains.helmunder "Public HTTP chart repositories", next toprometheus-community.github.io,grafana.github.ioandjaegertracing.github.io:kedacore.github.ioindex.yamland chart.tgzon the same host)helm repo add kedacore https://kedacore.github.io/charts); GitHub Pages of thekedacoreorgkyverno.github.ioindex.yamland.tgzon the same host)helm repo add kyverno https://kyverno.github.io/kyverno/); GitHub Pages of thekyvernoorgargoproj.github.iogithub.com/argoproj/argo-helm/releaseshelm repo add argo https://argoproj.github.io/argo-helm); GitHub Pages of theargoprojorgopen-telemetry.github.iogithub.com/open-telemetry/opentelemetry-helm-charts/releasesopen-telemetryorgkubernetes-sigs.github.iogithub.com/kubernetes-sigs/external-dns/releaseskubernetes-sigsorgvmware-tanzu.github.iogithub.com/vmware-tanzu/helm-charts/releasesvmware-tanzuorgbitnami.github.iogithub.com/bitnami/sealed-secrets/releaseshelm repo add sealed-secrets https://bitnami.github.io/sealed-secrets); GitHub Pages of thebitnamiorgcharts.external-secrets.io302tohttps://external-secrets.io/index.yamlhelm repo add external-secrets https://charts.external-secrets.io); TLS certCN=charts.external-secrets.io; CNAMEghs.googlehosted.comexternal-secrets.ioindex.yaml; tarballs ongithub.com/external-secrets/external-secrets/releasesexternal-secrets/external-secretsGitHub Pages site (Pages APIcname: external-secrets.io); TLS certCN=external-secrets.io; resolves to the GitHub Pages addressesTarball hosts are already covered:
github.comand.githubusercontent.com(release asset redirects) are ingithub_infra_domains, and the two hosts that serve tarballs themselves (kedacore.github.io,kyverno.github.io) are in this list.Anything you want to highlight for special attention from reviewers?
*.github.ioentries are single orgs' GitHub Pages hosts, in the same form as the existingprometheus-community.github.io/grafana.github.io/jaegertracing.github.ioentries. No*.github.iowidening, and the existingattacker.github.iocheck inTestEgressAllowlist_AddedMissingDomainsAllowedstill passes.external-secrets.iois also the project's docs site. It's here because it is where the canonical chart repo URL redirects to, not for changelog links. Without it, external-secrets helm updates fail outright.registries:. We tried declaring these as anonymoushelm-registryentries independabot.ymlfirst. The config validator rejects them (did not match one or more of the required schemas) becausehelm-registryrequiresusername/password, so public anonymous chart repos can't be allowed that way.jaegertracing.github.io, so whichever merges second needs a trivial rebase.How will you know you've accomplished your goal?
TestEgressAllowlist_AddedMissingDomainsAllowedfor the realindex.yamlpath on each host.evil.<host>) added toTestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHostsfor all nine entries, plus a sibling probeattacker.external-secrets.io. Checked that the child probes bite: switching all nine entries to leading-dot form makes the test fail withnew entries must not widen to: https://evil.<host>/payloadfor each of the nine. Reverted afterwards.verify_hostroutine from.github/skills/add-egress-allowlist-domain: all addresses are public, eachindex.yamlreturns anonymous200(exceptcharts.external-secrets.io, a single302toexternal-secrets.io, which was checked as its own hop), and the cert subjects are as listed above.Checklist
script/test(Docker,-race -shuffle=on -count=2) passes;yamllint,gofmt -l,go vet ./...andgo mod tidy -diffare clean.