Skip to content

Bump pydantic, azure-servicebus and aiolimiter - #445

Merged
sveinse merged 2 commits into
custom-components:masterfrom
steinmn:bump_pydantic_azurebus_aiolimiter
Oct 20, 2026
Merged

sveinse merged 2 commits into
custom-components:masterfrom
steinmn:bump_pydantic_azurebus_aiolimiter

Conversation

@steinmn

@steinmn steinmn commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Current core dev-branch includes a bump of pydantic, so we need to include this in 0.8.8 @sveinse. @rhammen mentions testing azure-servicebus==7.15.0 in #442 (comment), so that should be ok as well. Aiolimiter appears to barely be updating anything, other than dropping python 3.9.

Hassfest test fails due to "Requirement azure-servicebus==7.15.0 is incompatible with azure-servicebus==7.10.0, which Home Assistant depends on." HA core dev-branch has already updated to 7.15 in home-assistant/core@c44cc4e, so that should stop failing once we hit HA 2026.11.0. Not sure why this test hasn't failed before, since we have been on 7.14 as long as I can remember, and the 7.10-requirement was added in May 🤷

@steinmn steinmn mentioned this pull request Oct 17, 2026
@rhammen

rhammen commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Heads-up: even with HA 2026.11 (core already on 7.15.0), azure-servicebus==7.15.0 will still fail hassfest. The same check also rejects exact == pins on packages HA itself depends on, even when the versions match:

Requirement azure-servicebus==7.15.0 pins a package Home Assistant depends on (azure-servicebus==7.15.0). Use a minimum version ("azure-servicebus>=7.15.0") instead, ...

So I'd suggest "azure-servicebus>=7.15.0" (or >=7.15.0,<8 if we want an upper bound), plus requiring HA 2026.11+.

Why it only started failing now: the check was added in home-assistant/core#181913 (merged 2026-09-14), and the hassfest:latest image only gets it from 2026.10.0b0 (2026-09-30), so our first run after that, on 2026-10-05, failed while still on 7.14.3.

@steinmn

steinmn commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Interesting. I've updated all manifest.json deps to be a range. aiolimiter does not appear in HA requirements_all.txt (yet), but staying consistent seems reasonable, and it might get added in the future.

I don't think requiring HA 2026.11+ makes sense:

  1. It means noone will be able to upgrade the zaptec integration until 2026.11.0 is released.
  2. As far as I can tell, only the Azure Sevice Bus-integration requires the azure-servicebus-package, and it is listed as being used in a grand total of 4 installation (which could explain why we've never heard of any issues with incompatible versions)

@sveinse sveinse added this to the v0.8.8 milestone Oct 20, 2026

@sveinse sveinse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sveinse
sveinse merged commit 2c8a7ea into custom-components:master Oct 20, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants