Repository navigation
Conversation
Contributor
Author
|
The fullrun on this pull request (job 115234268041) shows the pin working. The job is still red because every Once #51 is merged, I'll rebase this branch onto it and re-run the fullrun. |
Delta Chat 2.63 stopped writing addr and mail_pw. The v2.29.1 deltachat-test harness still reads those keys, so test-madmail logs in with an empty username. The harness fix is on madmail main and is not in a release tag.
hpk42
force-pushed
the
madmail-default-main
branch
from
October 14, 2026 10:46
217d9d1 to
46ad0e9
Compare
Contributor
|
i fixed this in #53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-madmailwith no--sourcechecks outMadmailDriver.DEFAULT_REF. Nightly andtests/fullrun.pyboth use that default, which isv2.29.1.Delta Chat 2.63 stopped writing
addrandmail_pw. The harness at that tag still reads them, sotest-madmailcallssmtp.loginwith an empty username and the server answers535 5.7.8 Invalid credentials. That is the remaining failure in the re-run of #51 (job 114755625946).The harness fix is on madmail
main(themadorg/madmail#209). It is a test-only commit, so it is not inv2.35.0or the current GitHub latest,v2.30.5.mainis not avX.Y.Ztag, so the release-asset download is skipped and the existing source build runs. Relay deploy in these jobs already uses@main. A later fetch can followorigin/main.missytake agreed that testing against madmail
mainand chatmail/relaymainmakes sense.