Skip to content

madmail: default to main - #52

Closed
KamyarAT wants to merge 1 commit into
chatmail:mainfrom
KamyarAT:madmail-default-main
Closed

KamyarAT wants to merge 1 commit into
chatmail:mainfrom
KamyarAT:madmail-default-main

Conversation

@KamyarAT

Copy link
Copy Markdown
Contributor

deploy-madmail with no --source checks out MadmailDriver.DEFAULT_REF. Nightly and tests/fullrun.py both use that default, which is v2.29.1.

Delta Chat 2.63 stopped writing addr and mail_pw. The harness at that tag still reads them, so test-madmail calls smtp.login with an empty username and the server answers 535 5.7.8 Invalid credentials. That is the remaining failure in the re-run of #51 (job 114755625946).

The harness fix is on madmail main (themadorg/madmail#209). It is a test-only commit, so it is not in v2.35.0 or the current GitHub latest, v2.30.5.

main is not a vX.Y.Z tag, so the release-asset download is skipped and the existing source build runs. Relay deploy in these jobs already uses @main. A later fetch can follow origin/main.

missytake agreed that testing against madmail main and chatmail/relay main makes sense.

@KamyarAT

Copy link
Copy Markdown
Contributor Author

The fullrun on this pull request (job 115234268041) shows the pin working. test_madmail against madmail main passed, including test 2, which was the 535 login failure on v2.29.1. The accounts came up with real addresses.

The job is still red because every cmlxc test-mini fails in test_relay.py test_hide_senders_ip_address: get_config("addr") is None on Delta Chat 2.63.0, and .split crashes. This branch is cut from current main, before the fix already approved in #51. Relay's own pytest passed (114, and the IPv4 run 107 with 7 skipped).

Once #51 is merged, I'll rebase this branch onto it and re-run the fullrun.

Delta Chat 2.63 stopped writing addr and mail_pw. The v2.29.1
deltachat-test harness still reads those keys, so test-madmail
logs in with an empty username. The harness fix is on madmail
main and is not in a release tag.
@hpk42
hpk42 force-pushed the madmail-default-main branch from 217d9d1 to 46ad0e9 Compare October 14, 2026 10:46
@hpk42

hpk42 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

i fixed this in #53

@hpk42 hpk42 closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants