Skip to content

Preserve explicit epoch-zero bounds on time scales #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakarrr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Preserve explicit epoch-zero bounds on time scales #12360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ccf33
fix(time): preserve explicit epoch-zero bounds
hakarrr Oct 25, 2026
02f9f67
test(time): cover zero bounds with label and generated ticks
hakarrr Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scales/scale.time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,8 @@ export default class TimeScale extends Scale {
const timestamps = tickOpts.source === 'labels' ? this.getLabelTimestamps() : this._generate();

if (options.bounds === 'ticks' && timestamps.length) {
this.min = this._userMin || timestamps[0];
this.max = this._userMax || timestamps[timestamps.length - 1];
this.min = isNullOrUndef(this._userMin) ? timestamps[0] : this._userMin;
this.max = isNullOrUndef(this._userMax) ? timestamps[timestamps.length - 1] : this._userMax;
}

const min = this.min;
Expand Down
18 changes: 18 additions & 0 deletions test/specs/scale.time.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,24 @@ describe('Time scale tests', function() {
return scale.ticks.map(t => t.label);
}

['time', 'timeseries'].forEach(function(type) {
['min', 'max'].forEach(function(bound) {
['labels', 'auto'].forEach(function(source) {
it('should preserve an explicit epoch-zero ' + bound + ' for ' + type + ' with ' + source + ' ticks', function() {
var labels = bound === 'min' ? [1000, 2000] : [-2000, -1000];
var options = {type: type, bounds: 'ticks', ticks: {source: source}, time: {unit: 'second'}};
options[bound] = 0;
var chart = window.acquireChart({
type: 'line',
data: {labels: labels, datasets: [{data: [1, 2]}]},
options: {animation: false, scales: {x: options}}
});
expect(chart.scales.x[bound]).toBe(0);
});
});
});
});

beforeEach(function() {
// Need a time matcher for getValueFromPixel
jasmine.addMatchers({
Expand Down