Skip to content

fix: download the main jar for supply-chain indexing - #423

Merged
algomaster99 merged 3 commits into
mainfrom
fix/jar-downloader-main-artifact
Nov 10, 2026
Merged

algomaster99 merged 3 commits into
mainfrom
fix/jar-downloader-main-artifact

Conversation

@algomaster99

@algomaster99 algomaster99 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Index the jar that is actually on the classpath.

  • JarDownloader took the first .jar in the repository listing that was not sources/javadoc/tests. Classifier jars can sort first: snakeyaml-1.33-android.jar, groovy-4.0.28-grooid.jar. Their classes hash differently, so the watchdog flagged library classes as [MODIFIED] (e.g. org/yaml/snakeyaml/introspector/PropertyUtils).
  • It now picks exactly <artifactId>-<version>.jar, matching on the file name so absolute hrefs (JBoss) still work.
  • SupplyChainIndexerTest.useMD5asAlgorithm now expects 17948 classes instead of 17790. In the PDFBox 3.0.0 SBOM, the old code indexed commons-logging-1.2-adapters.jar and commons-net-3.9.0-examples.jar (example programs, not the library) in place of the main jars.

algomaster99 and others added 2 commits November 10, 2026 17:28
…dexing

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@algomaster99 algomaster99 changed the title fix: download the main jar, not a classifier jar, for supply-chain indexing fix: download the main jar for supply-chain indexing Nov 10, 2026
…Box index

The old count included commons-logging-1.2-adapters.jar and
commons-net-3.9.0-examples.jar, which JarDownloader picked instead of the main jars.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@algomaster99
algomaster99 merged commit 9ec2255 into main Nov 10, 2026
9 checks passed
@algomaster99
algomaster99 deleted the fix/jar-downloader-main-artifact branch November 10, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant