Repository navigation
Conversation
Replace all 4 cast() calls in reports/graphs.py with assert isinstance() or assert is not None. This provides both static type safety (mypy narrowing) and runtime validation instead of unchecked type casts. The cast(F, new_f) in utils.py is intentionally retained — it handles a fundamental typing limitation with decorator wrappers that cannot be expressed via isinstance. Fixes capitalone#720
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all 4
cast()calls inreports/graphs.pywithassert isinstance()orassert is not None. This provides both static type safety (mypy narrowing) and runtime validation instead of unchecked type casts.Changes
cast(List[Union[str, int]], column_names)assert column_names is not Nonecast(ColumnPrimitiveTypeProfileCompiler, ...)assert isinstance(...)cast(Figure, ax.figure)assert ax.figure is not NoneThe
cast(F, new_f)inutils.pyis intentionally retained — it handles a typing limitation with decorator wrappers.Fixes #720
Previously submitted as #1218 (closed) and #1222 (targeted stale
devbranch). Clean resubmission againstmain.