Repository navigation
Conversation
This was referenced Oct 20, 2026
Contributor
Author
Review ledger{
"findings": [
{
"id": "R1",
"role": "code",
"class": "spec: never Nothing needs you on failed read",
"outcome": "fixed",
"path": "ui/src/state/inbox.ts:38",
"fix": "a080f908"
},
{
"id": "R2",
"role": "code",
"class": "spec Failure modes: could not check hidden",
"outcome": "fixed",
"path": "ui/src/screens/overview/index.tsx:213",
"fix": "a080f908"
},
{
"id": "R3",
"role": "code",
"class": "testing 3",
"outcome": "fixed",
"path": "ui/src/state/inbox.ts:41",
"fix": "a080f908"
},
{
"id": "R4",
"role": "spec",
"class": "specification line delivered differently",
"outcome": "fixed",
"path": "ui/src/screens/overview/index.tsx:165",
"fix": "a080f908"
},
{
"id": "R5",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"path": "docs/CONSOLE.md:521",
"fix": "25c2adff"
},
{
"id": "R6",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"path": "docs/internal/DESIGN.md:241",
"fix": "25c2adff"
},
{
"id": "R7",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"path": "ui/AGENTS.md:84",
"fix": "25c2adff"
},
{
"id": "R8",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"path": "ui/src/model/inbox.ts:476",
"fix": "25c2adff"
},
{
"id": "R9",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"path": "ui/src/screens/leases/leases.test.tsx:148",
"fix": "25c2adff"
},
{
"id": "R10",
"role": "claims",
"class": "architecture 13",
"outcome": "duplicate",
"canonicalId": "R2",
"path": "docs/CONSOLE.md:252"
},
{
"id": "R11",
"role": "spec",
"class": "testing 7",
"outcome": "nonblocking",
"path": "ui/src/screens/overview/overview.test.tsx:63"
},
{
"id": "R12",
"role": "code",
"class": "spec: stale data shown after failed read",
"outcome": "fixed",
"fix": "768625ac",
"path": "ui/src/state/inbox.ts:49"
},
{
"id": "R13",
"role": "claims",
"class": "architecture 13",
"outcome": "fixed",
"fix": "768625ac",
"path": "docs/internal/DESIGN.md:33"
}
]
}Written by an agent. |
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
V3RON
marked this pull request as ready for review
October 21, 2026 09:13
V3RON
added this pull request to stack #781
October 21, 2026 09:13
…'s key and tone (#768)
…s model and reason (#768)
…both by the daemon's now (#768)
…t its deadline says ends now; the Leases filter agrees (#768)
…, and the Leases filter says Ending < 5 min (#768)
…wait first, least time left first (#768)
…he problem count excludes heads-ups (#768)
…ds you panel; with a disconnected worker it shows the panel with that item first, and the link All in Inbox (n) (#768)
…ur Inbox problems with a link to all of them (#768)
…t check: waiting requests and not Nothing needs you (#768)
…hat read failed, and never Nothing needs you then (#768)
…nding soon counts a lease with 4 minutes left and not one with 10 (#768)
…Ending soon, and reads the leases and tokens (#768)
…r's ready device counts as drained, a disconnected worker's devices as offline, a shutdown device as shut down, a deleted one not at all (#768)
…pen Fleet goes to /fleet (#768)
…the item's details; a cleared item says This is no longer in the Inbox. (#768)
…hat-happened box and the item's details (#768)
…request and a lease is tested (#768)
…: workers and shows no capacity (#768)
…s cannot be read (#768)
…ot check: waiting requests and not Nothing needs you (#768)
…backs and the counts they claimed (#768) The website console mock names the Inbox.
…he plural, the dotted address and the row width (#768)
… names a read that failed behind an earlier answer (#768)
… the gateway-only Inbox items, no inspector in the design notes (#768)
…ers read is named in Could not check; the drawer replaces the inspector in the notes (#768)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768
Status
Implement: done (179/179 Chromium console lane) Review: round 2 and fix-check passed Hardware: n/a Gate: waiting for the stack
Built: Overview (five numbers, Needs you, Capacity, two charts, Fleet's workers table, "Could not check"), Usage in the shared frame, the Inbox (three groups, group chips, the drawer at
/inbox/<key>, the sidebar problem count), and the docs.Done when
pnpm test:console --project=chromiumpasses, and CI's Console check passes in every browser. Checked: 179/179 Chromium locally; Firefox and WebKit in CI on the head.Assumptions
absentReason— it is titled(not-present), the plain reason, so the title never printsundefined.EXPIRING_UNDER_MSstays private tomodel/leases.ts, which exportsisExpiringinstead; nothing else needs the constant.Review
Spec review: 1 blocking, 1 fixed, 0 notes. Code review: 4 blocking, 4 fixed, 0 notes. Claims review: 6 blocking, 6 fixed, 1 notes.
Rounds: 2. Tokens: 9.0M.
Runs: 15. Cost USD: 18.9714. Agent seconds: 19251.
Assessment: complete
Rejected:
Written by an agent.