Skip to content

ci: Compile with minimum supported g++-10 in olddeps #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanofsky merged 1 commit into from
Oct 1, 2026
Merged

ci: Compile with minimum supported g++-10 in olddeps #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci/configs/olddeps.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
CI_DESC="CI job using old Cap'n Proto and cmake versions"
CI_DIR=build-olddeps
# Pin olddeps to an older Nixpkgs channel, since compiling the old CMake
# requires an older GCC.
# Pin olddeps to an older Nixpkgs channel, to be able to test an older GCC.

@ryanofsky ryanofsky Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible followup: this comment could keep the old reason too, and say that 25.05 is the last channel with GCC 10 (25.11 and unstable only have gcc13 and later), so whoever bumps the channel knows the job's GCC version has to change with it. Maybe something like:

# Pin olddeps to an older Nixpkgs channel, since nixos-25.05 is the last
# channel providing GCC 10, and compiling the old CMake requires an older GCC.

CI_NIXPKGS_CHANNEL=nixos-25.05
export CXXFLAGS="-Werror -Wall -Wextra -Wpedantic -Wno-unused-parameter -Wno-error=array-bounds"
NIX_ARGS=(--argstr capnprotoVersion "0.9.2" --argstr cmakeVersion "3.12.4" --argstr gccVersion "11")
CAPNP_CHECKOUT=v0.9.2 # Use a checkout to compile it with the selected GCC

@ryanofsky ryanofsky Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible followup: it might not be obvious why this builds Cap'n Proto from source when nix has a package for it. The comment could say what this is trying to test, something like:

# Build Cap'n Proto from source so it is compiled with the same old GCC, like
# on a system where that GCC is the default compiler. Nix packages are built
# with the channel's default GCC instead.

NIX_ARGS=(--argstr capnprotoVersion "none" --argstr cmakeVersion "3.12.4" --argstr gccVersion "10")
BUILD_ARGS=(-k)
2 changes: 1 addition & 1 deletion ci/scripts/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if [ -n "${CAPNP_CHECKOUT-}" ]; then
git --no-pager log -1 || true
CXXFLAGS="-std=c++20" cmake .. "-DCMAKE_INSTALL_PREFIX=${capnp_prefix}" -DBUILD_TESTING=OFF -DWITH_OPENSSL=OFF -DWITH_ZLIB=OFF
cmake --build .
cmake --install .
cmake --build . --target install # Replacement for modern "cmake --install .".
)
export CMAKE_PREFIX_PATH="${capnp_prefix}:${CMAKE_PREFIX_PATH-}"
fi
Expand Down
Loading