Repository navigation
feat: add daylight planner dock cards - #154
Closed
michaeljolley wants to merge 1 commit into
Closed
michaeljolley wants to merge 1 commit into
michaeljolley wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dock card now puts current weather beside a location-local daylight planner, followed by the next three hours and a three-day outlook with rain chances. It uses standard Adaptive Cards 1.5, locally generated PNG artwork, explicit nighttime and unavailable states, and labels for all 15 shipped locales without changing dock pinning or other weather pages.
Validation
Build commands use a session-only
SafeBuild.targetscontaining<Project><Target Name="KillRunningExecutable" /></Project>so validation doesn't kill a running extension.dotnet build WeatherExtension\WeatherExtension.csproj -r win-x64 --no-restore -p:Platform=x64 -p:CustomAfterMicrosoftCommonTargets="C:\Users\Michael\.copilot\session-state\175297a6-0eb4-4547-95aa-5795ac32089c\files\SafeBuild.targets" -v:quietdotnet build WeatherExtension.Tests\WeatherExtension.Tests.csproj -r win-x64 --no-restore -p:Platform=x64 -p:CustomAfterMicrosoftCommonTargets="C:\Users\Michael\.copilot\session-state\175297a6-0eb4-4547-95aa-5795ac32089c\files\SafeBuild.targets" -v:quietdotnet test WeatherExtension.Tests\WeatherExtension.Tests.csproj -r win-x64 -p:Platform=x64 --no-build --filter "FullyQualifiedName~WeatherCardPresentationTests|FullyQualifiedName~HourlyForecastTests" -v:minimal|here only to escape the Markdown table separator; remove the backslash when running it.dotnet test WeatherExtension.Tests\WeatherExtension.Tests.csproj -r win-x64 -p:Platform=x64 --no-build --filter "FullyQualifiedName!~RollingFileLoggerTests" -v:minimaldotnet test WeatherExtension.Tests\WeatherExtension.Tests.csproj -r win-x64 -p:Platform=x64 --no-build -v:minimaldotnet build WeatherExtension\WeatherExtension.csproj -c Release -r win-x64 --no-restore -p:Platform=x64 -p:CustomAfterMicrosoftCommonTargets="C:\Users\Michael\.copilot\session-state\175297a6-0eb4-4547-95aa-5795ac32089c\files\SafeBuild.targets" -v:quietdotnet build WeatherExtension\WeatherExtension.csproj -c Release -r win-x64 --no-restore -p:Platform=x64 -p:GenerateAppxPackageOnBuild=false -p:CustomAfterMicrosoftCommonTargets="C:\Users\Michael\.copilot\session-state\175297a6-0eb4-4547-95aa-5795ac32089c\files\SafeBuild.targets" -v:quietnode "C:\Users\Michael\.copilot\session-state\175297a6-0eb4-4547-95aa-5795ac32089c\files\verify-production.cjs"git diff --checkandgit diff --cached --checkThe preview uses Microsoft's JavaScript renderer and Command Palette's published HostConfig, not the installed native flyout. Native Adaptive Cards source confirms PNG data URI support, but native flyout appearance remains unverified; unrelated logger and packaging files are unchanged.
Requirement evidence
Build_LocationAcrossDateBoundary_SelectsLocationDayAndFutureHours,Build_ExactCurrentHour_SkipsItAndMarksNightForecast,WeatherCardPresentation_SpanningMidnight_FindsThreeFutureHoursBuild_DaylightBoundaries_ClampProgressAndLabelPhase,DaylightImage_AfterSunset_RemovesTheDaytimeMarkerBuild_DaylightAcrossDstChange_UsesElapsedTimeForDurationAndProgress,Build_NonexistentDstTime_MarksDaylightUnavailable,Build_AmbiguousDstTime_MarksDaylightUnavailable,Build_InvalidDaylight_KeepsForecastAndExplicitUnavailableStatusBuild_ShortForecastArrays_DoesNotInventZeroReadings,Build_MissingForecasts_LeavesCurrentConditionsAndLocalTimeAvailable,Build_ClockAndUnitPreferences_FormatsTimesAndReadings,Serialize_QuotedLocationAndUnavailableState_PreservesTextAndOmitsCalculationFields,PopulateImages_DaylightAndNight_ProducesDecodableLocalPngs,AllShippedLocales_HaveDaylightLabelsAndValidFormatPlaceholdersRelated Issue
N/A. Requested directly.
Checklist
dotnet build -r win-x64)dotnet test -r win-x64)Build and test evidence above uses explicit project paths, as CI does; Release MSIX packaging and the eight externally locked logger cases are not passing.